-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Client encryption]: Add JsonNodeSqlSerializer #4779
Merged
kirankumarkolli
merged 59 commits into
Azure:master
from
juraj-blazek:users/jan-hyka/jsonnode_serializer
Oct 10, 2024
Merged
[Client encryption]: Add JsonNodeSqlSerializer #4779
kirankumarkolli
merged 59 commits into
Azure:master
from
juraj-blazek:users/jan-hyka/jsonnode_serializer
Oct 10, 2024
+190
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tps://github.com/juraj-blazek/azure-cosmos-dotnet-v3 into users/juraj-blazek/encryption-benchmark-baseline
…encryption-array-pooling
…encryption-array-pooling
~ reduce validations overhead
~ update api file
…/jan-hyka/refactor-encryption-processor
+ Address new compiler complaints
! JObjectSqlSerializer remove formatting on serializing inner arrays/objects to string
JanHyka
requested review from
kirillg,
kirankumarkolli,
FabianMeiswinkel,
sboshra and
Pilchie
as code owners
October 9, 2024 09:29
~ Microsoft.Azure.Cosmos.Encryption.Custom now references System.Text.Json 8.0.5 as per security advisory
...t.Azure.Cosmos.Encryption.Custom.Tests/Microsoft.Azure.Cosmos.Encryption.Custom.Tests.csproj
Show resolved
Hide resolved
kirankumarkolli
approved these changes
Oct 10, 2024
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
kirankumarkolli
pushed a commit
that referenced
this pull request
Oct 15, 2024
# Pull Request Template ## Description - Added support for System.Text.JsonNode DOM on encryption path - Configuration option to select Json Processor (defaults to Newtonsoft) - Custom byte[] coverter supporting offset+length for JsonNode - Perf tests expanded to cover both json processors (JsonNode decryption still uses Newtonsoft, this will be upgraded with further PRs) To be processed after #4779 ## Type of change Please delete options that are not relevant. - [] New feature (non-breaking change which adds functionality) - [] This change requires a documentation update ## Closing issues Contributes to #4678 --------- Co-authored-by: Juraj Blazek <[email protected]> Co-authored-by: juraj-blazek <[email protected]> Co-authored-by: Santosh Kulkarni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Initial commit for JsonNode on Encryption path. This is currently not executed on any production/preview path. Depends on JsonNode features available from System.Text.Json 8.0+.
To be processed after #4766
Type of change
Please delete options that are not relevant.
Closing issues
Contributes to #4678