[Client encryption]: Adds support for Brotli compression #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tps://github.com/juraj-blazek/azure-cosmos-dotnet-v3 into users/juraj-blazek/encryption-benchmark-baseline
…encryption-array-pooling
…encryption-array-pooling
~ reduce validations overhead
~ update api file
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Microsoft.Azure.Cosmos.Encryption.Custom/src/Transformation/MdeEncryptionProcessor.Preview.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos.Encryption.Custom/src/Transformation/BrotliCompressor.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos.Encryption.Custom/src/Transformation/BrotliCompressor.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos.Encryption.Custom/src/Transformation/BrotliCompressor.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos.Encryption.Custom/src/Transformation/BrotliCompressor.cs
Show resolved
Hide resolved
|
Can you please update the description with usage details (will help consumers) |
kirankumarkolli
previously approved these changes
Oct 11, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kirankumarkolli
changed the title
added 2 commits
October 11, 2024 22:11
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Microsoft.Azure.Cosmos.Encryption.Custom/src/CompressionOptions.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Brotli compression is now available for .NET8.0 target. All encrypted fields matching criteria are compressed before encryption.
The option is configurable via
Microsoft.Azure.Cosmos.Encryption.Custom.EncryptionOptionspropertyCompressionOptionsCompressionOptionsstructure:Algorithm:CompressionOptions.CompressionAlgoritmsuportsNoneandBrotli(for .NET8.0+), defaults to None.CompressionLevel:System.IO.Compression.CompressionLevel- defaults to CompressionLevel.FastestMinimalCompressedLength: determines minimal size of encrypted serialized Json text for compression. Defaults to 128 bytes.It is suggested to benchmark your use cases, different settings can lead to different ratio of compute vs storage costs. Default settings in general should save both cpu time and memory consumption.
Warn: make sure all your instances are upgraded to version supporting compression BEFORE enabling it.
To be processed after #4766
Type of change
Please delete options that are not relevant.
Closing issues
Contributes to #4678