[Client encryption]: Switch Newtonsoft.Json to use ArrayPool #4726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanHyka
requested review from
kirankumarkolli,
FabianMeiswinkel,
sboshra and
Pilchie
as code owners
kirankumarkolli
approved these changes
Sep 27, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Switches usages of
JsonTextReaderandJsonTextWriterto useArrayPool<char>.Sharedfor better performance and reduced memory allocations. Arrays returned to pool are zeroed for increased data security (at benchmarked cost of ~3.5% extra mean compared to non-zeroed returns).Type of change
Please delete options that are not relevant.
Closing issues
Contributes to #4678