Open Telemetry : Adds query text in attribute #4664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
FabianMeiswinkel,
adityasa,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
sourabh1007
force-pushed
the
users/sourabhjain/addqueryTextinOtel
branch
3 times, most recently
from
2f7c8e7 to
e663af5
Compare
sourabh1007
force-pushed
the
users/sourabhjain/addqueryTextinOtel
branch
from
816b162 to
8e29f00
Compare
jcocchi
reviewed
Sep 17, 2024
Contributor
jcocchi
left a comment
jcocchi
left a comment
There was a problem hiding this comment.
Do we want to have an opt in to also capture parameter values attributes? This is described in the otel conventions, but we can always go back and add it if there's demand later.
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryCoreRecorder.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryRecorderFactory.cs
Outdated
Show resolved
Hide resolved
sourabh1007
force-pushed
the
users/sourabhjain/addqueryTextinOtel
branch
from
9b3858e to
35201c3
Compare
joegoldman2
reviewed
Sep 20, 2024
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/ShowQueryMode.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/ChangeFeed/ChangeFeedIteratorCore.cs
Outdated
Show resolved
Hide resolved
Member
|
Reqeustlevel override feels over engineering, Thoughts? |
Contributor
Author
It is taken from Java SDK and I believe, It will provide customers with the option to enable or disable the inclusion of query text in OpenTelemetry (OTel) traces for specific types of queries. |
sourabh1007
force-pushed
the
users/sourabhjain/addqueryTextinOtel
branch
from
6343391 to
23b13bf
Compare
philipthomas-MSFT
previously approved these changes
Sep 25, 2024
Contributor
philipthomas-MSFT
left a comment
philipthomas-MSFT
left a comment
There was a problem hiding this comment.
Nothing major from me. LGTM. just one nit. Everything else looks good.
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/QueryTextMode.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/RequestOptions/ChangeFeedRequestOptions.cs
Outdated
Show resolved
Hide resolved
sourabh1007
force-pushed
the
users/sourabhjain/addqueryTextinOtel
branch
from
d64896a to
74a59ac
Compare
kirankumarkolli
approved these changes
Oct 4, 2024
5 tasks
This was referenced Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
db.query.textattribute to record queries in Traces.QueryTextMode, which will have valid values asa)
None:Do not show query.b)
ParameterizedOnly: Print parameterized query only.b)
AllCosmosClientTelemetryOptionsandRequestOptions(i.e.QueryRequestOptionsandChangeFeedRequestOptions)Type of change