-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ContainerProperties: Refactors Vector Embedding and Indexing Policy Interfaces to Mark Them as Public for Preview #4486
Merged
kirankumarkolli
merged 9 commits into
master
from
users/kundadebdatta/make_vector_search_public
May 15, 2024
Merged
ContainerProperties: Refactors Vector Embedding and Indexing Policy Interfaces to Mark Them as Public for Preview #4486
kirankumarkolli
merged 9 commits into
master
from
users/kundadebdatta/make_vector_search_public
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kundadebdatta
changed the title
ContainerProperties: Refactors Vector Embedding and Indexing Policy Interfaces to Mark Them as Public
ContainerProperties: Refactors Vector Embedding and Indexing Policy Interfaces to Mark Them as Public for Preview
May 13, 2024
kundadebdatta
requested review from
a team,
kirankumarkolli,
ealsur,
FabianMeiswinkel,
kirillg and
sboshra
as code owners
May 13, 2024 22:15
1 task
philipthomas-MSFT
previously approved these changes
May 13, 2024
ealsur
reviewed
May 13, 2024
Microsoft.Azure.Cosmos/src/Fluent/Settings/VectorEmbeddingPolicyDefinition.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/DotNetSDKAPI.json
Outdated
Show resolved
Hide resolved
ealsur
reviewed
May 13, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/DotNetSDKAPI.json
Outdated
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
May 14, 2024
ealsur
previously approved these changes
May 15, 2024
ealsur
reviewed
May 15, 2024
kirankumarkolli
approved these changes
May 15, 2024
ealsur
approved these changes
May 15, 2024
kirankumarkolli
added
auto-merge
Enables automation to merge PRs
and removed
auto-merge
Enables automation to merge PRs
labels
May 15, 2024
1 task
microsoft-github-policy-service bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
…nterfaces to Mark Them as Public for GA (#4845) # Pull Request Template ## Description The purpose of this PR is to mark the new `VectorEmbeddingPolicy` in the `ContainerProperties` as a public surface interface for `GA` release, and introducing new `VectorIndexes` in the `IndexingPolicy` to enable Vector Similarity Search in Cosmos DB ecosystem. Relevant PRs for the vector similarity work: - [ContainerProperties: Adds Vector Embedding and Indexing Policy](#4379) - [ContainerProperties: Refactors Vector Embedding and Indexing Policy Interfaces to Mark Them as Public for Preview](#4486) - [VectorIndexDefinition: Adds Support for Partitioned DiskANN](#4792) ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) ## Closing issues To automatically close an issue: closes #4825
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
The purpose of this PR is to mark the new
VectorEmbeddingPolicy
in theContainerProperties
as a public surface interface forpreview
release, and introducing newVectorIndexes
in theIndexingPolicy
to enable Vector Similarity Search in Cosmos DB.Relevant PR for the vector similarity work: 4379
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #4364