ChangeFeedProcessor: Fixes a bug properly when dealing with Legacy lease incremental documents that do not have a Mode property #4426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipthomas-MSFT
requested review from
FabianMeiswinkel,
adityasa,
ealsur,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
…rbuilder-throws-exception-for-changefeedmode-on-3.39.0-4423
ealsur
reviewed
Apr 17, 2024
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Apr 17, 2024
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Apr 17, 2024
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Apr 17, 2024
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Show resolved
Hide resolved
ealsur
reviewed
Apr 17, 2024
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Show resolved
Hide resolved
ealsur
reviewed
Apr 17, 2024
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Apr 17, 2024
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/LeaseManagement/DocumentServiceLeaseManager.cs
Outdated
Show resolved
Hide resolved
ealsur
requested changes
Apr 17, 2024
Member
ealsur
left a comment
ealsur
left a comment
There was a problem hiding this comment.
Waiting on the comparison clarification
…rbuilder-throws-exception-for-changefeedmode-on-3.39.0-4423
ealsur
approved these changes
Apr 17, 2024
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Show resolved
Hide resolved
ealsur
added
auto-merge
ealsur
deleted the
users/philipthomas-MSFT/changefeedprocessorbuilder-throws-exception-for-changefeedmode-on-3.39.0-4423
branch
philipthomas-MSFT
added a commit
that referenced
this pull request
Apr 17, 2024
… lease incremental documents that do not have a Mode property (#4426) * fix for 4423 * fix comment * some recommendation changes
philipthomas-MSFT
added a commit
that referenced
this pull request
Apr 18, 2024
… lease incremental documents that do not have a Mode property (#4426) * fix for 4423 * fix comment * some recommendation changes
philipthomas-MSFT
added a commit
that referenced
this pull request
Apr 18, 2024
… lease incremental documents that do not have a Mode property (#4426) * fix for 4423 * fix comment * some recommendation changes
microsoft-github-policy-service bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
* SDK 3.39.1/3.40.0-preview.1: Adds version bump and changelog. (#4430) * SDK 3.39.1/3.40.0-preview.1: Adds version bump and changelog. * Update changelog.md Co-authored-by: Matias Quaranta <[email protected]> --------- Co-authored-by: Matias Quaranta <[email protected]> Co-authored-by: Sourabh Jain <[email protected]> * ChangeFeedProcessor: Fixes ArgumentException when dealing with Legacy lease incremental documents that do not have a Mode property (#4426) * fix for 4423 * fix comment * some recommendation changes --------- Co-authored-by: Matias Quaranta <[email protected]> Co-authored-by: Sourabh Jain <[email protected]>
microsoft-github-policy-service bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
* SDK 3.39.1/3.40.0-preview.1: Adds version bump and changelog. (#4430) * SDK 3.39.1/3.40.0-preview.1: Adds version bump and changelog. * Update changelog.md Co-authored-by: Matias Quaranta <[email protected]> --------- Co-authored-by: Matias Quaranta <[email protected]> Co-authored-by: Sourabh Jain <[email protected]> * ChangeFeedProcessor: Fixes ArgumentException when dealing with Legacy lease incremental documents that do not have a Mode property (#4426) * fix for 4423 * fix comment * some recommendation changes --------- Co-authored-by: Matias Quaranta <[email protected]> Co-authored-by: Sourabh Jain <[email protected]>
This was referenced Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Refer to #4423 for details
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #4423