Skip to content

ChangeFeedProcessor: Fixes when ChangeFeedMode is switched should throw an exception. #4334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Mar 22, 2024
Merged

ChangeFeedProcessor: Fixes when ChangeFeedMode is switched should throw an exception. #4334

merged 22 commits into from
Mar 22, 2024

Conversation

@philipthomas-MSFT
Copy link
Contributor

@philipthomas-MSFT philipthomas-MSFT commented Feb 29, 2024

Pull Request Template

See #4308 for problem statement, repro, scenarios, expected behavior, etc.

Description

Please include a summary of the change and which issue is fixed. Include samples if adding new API, and include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Closing issues

To automatically close an issue: closes #4308

@philipthomas-MSFT philipthomas-MSFT self-assigned this Feb 29, 2024
@philipthomas-MSFT philipthomas-MSFT linked an issue Feb 29, 2024 that may be closed by this pull request
Change Feed Processor: Switching ChangeFeedMode should throw an exception #4308
Closed
@philipthomas-MSFT philipthomas-MSFT added the auto-merge Enables automation to merge PRs label Feb 29, 2024
@philipthomas-MSFT philipthomas-MSFT changed the title ChangeFeedProcessor: Fixes when ChangeFeedMode is switched should throw an exception. Also preparing CFP for Public Preview ChangeFeedProcessor: Fixes when ChangeFeedMode is switched should throw an exception. Mar 1, 2024
ealsur
ealsur requested changes Mar 1, 2024
View reviewed changes
ealsur
ealsur reviewed Mar 20, 2024
View reviewed changes
Copy link
Member

@ealsur ealsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress! Just some nit comments and one question for the broader crew in terms of the type of exception we want to throw. Open to discussion on it.

ealsur
ealsur previously approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@ealsur ealsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just make sure the exception type is something the rest agrees on :) Great work

kirankumarkolli
kirankumarkolli approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@kirankumarkolli kirankumarkolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the JSON casing part with Matias.

@philipthomas-MSFT
Merge branch 'master' into users/philipthomas-MSFT/4308-change-feed-p…
63d7b40 
…rocessor-switching-changefeedmode-should-throw-an-exception
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit dbdf806 into master Mar 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/philipthomas-MSFT/4308-change-feed-processor-switching-changefeedmode-should-throw-an-exception branch March 22, 2024 14:39
This was referenced Jul 28, 2025
Closed
Closed
@dependabot dependabot bot mentioned this pull request Aug 4, 2025
Open
@dependabot dependabot bot mentioned this pull request Sep 22, 2025
Closed
@dependabot dependabot bot mentioned this pull request Oct 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ealsur ealsur ealsur approved these changes

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@adityasa adityasa Awaiting requested review from adityasa adityasa is a code owner

@neildsh neildsh Awaiting requested review from neildsh neildsh is a code owner

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

Assignees

@philipthomas-MSFT philipthomas-MSFT

Labels

auto-merge Enables automation to merge PRs

Projects

Azure Cosmos SDKs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change Feed Processor: Switching ChangeFeedMode should throw an exception

4 participants

@philipthomas-MSFT @ealsur @kirankumarkolli