Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] Query: Adds single physical partition check for OptimisticDirectExecution queries #3699

Merged
merged 9 commits into from
Feb 17, 2023
Merged

[Internal] Query: Adds single physical partition check for OptimisticDirectExecution queries #3699

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
132ab7b
Added single physical partition check for Ode queries. Updated test i…
akotalwar Feb 7, 2023
bc23bfa
Refactored emulator tests to have all the test cases at the top of th…
akotalwar Feb 10, 2023
02bda3c
Updated TryGetTargetRangeOptimisticDirectExecutionAsync()
akotalwar Feb 13, 2023
94902df
Uodated logic on how many times CreateIngestQueryDeleteAsync() gets c…
akotalwar Feb 15, 2023
f6986e1
Added debug asserts for partitionKeyDefinition
akotalwar Feb 15, 2023
27ea927
Added pageSizeOptions parameter in CreateInput() in EmulatorTests
akotalwar Feb 16, 2023
7762bae
Fixed comments
akotalwar Feb 16, 2023
e4eaf8c
Merge branch 'master' into users/akotalwar/SinglePhysicalPartitionCheck
akotalwar Feb 17, 2023
54a257d
Merge branch 'master' into users/akotalwar/SinglePhysicalPartitionCheck
akotalwar Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/CosmosQueryExecutionContextFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,22 +755,9 @@ private static Documents.PartitionKeyDefinition GetPartitionKeyDefinition(InputP
{
if (!inputParameters.EnableOptimisticDirectExecution) return null;

// case 1: Is query going to a single partition
bool hasPartitionKey = inputParameters.PartitionKey.HasValue
&& inputParameters.PartitionKey != PartitionKey.Null
&& inputParameters.PartitionKey != PartitionKey.None;

// case 2: does query execution plan have a single query range
bool hasQueryRanges = partitionedQueryExecutionInfo != null
&& partitionedQueryExecutionInfo.QueryRanges.Count == 1
&& partitionedQueryExecutionInfo.QueryRanges[0].IsSingleValue;

if (!hasPartitionKey && !hasQueryRanges) return null;

//TODO: does collection have only one physical partition

List<Documents.PartitionKeyRange> targetRanges = new List<Documents.PartitionKeyRange>();
Debug.Assert(containerQueryProperties.ResourceId != null, "CosmosQueryExecutionContextFactory Assert!", "Container ResourceId cannot be null!");

List<Documents.PartitionKeyRange> targetRanges;
if (partitionedQueryExecutionInfo != null)
{
targetRanges = await CosmosQueryExecutionContextFactory.GetTargetPartitionKeyRangesAsync(
Expand All @@ -785,15 +772,26 @@ private static Documents.PartitionKeyDefinition GetPartitionKeyDefinition(InputP
else
{
Documents.PartitionKeyDefinition partitionKeyDefinition = GetPartitionKeyDefinition(inputParameters, containerQueryProperties);
if (partitionKeyDefinition != null && containerQueryProperties.ResourceId != null && inputParameters.PartitionKey != null)
if (inputParameters.PartitionKey != null)
{
akotalwar marked this conversation as resolved.
Show resolved Hide resolved
Debug.Assert(partitionKeyDefinition != null, "CosmosQueryExecutionContextFactory Assert!", "PartitionKeyDefinition cannot be null if partitionKey is defined");

targetRanges = await cosmosQueryContext.QueryClient.GetTargetPartitionKeyRangesByEpkStringAsync(
cosmosQueryContext.ResourceLink,
containerQueryProperties.ResourceId,
inputParameters.PartitionKey.Value.InternalKey.GetEffectivePartitionKeyString(partitionKeyDefinition),
forceRefresh: false,
trace);
akotalwar marked this conversation as resolved.
Show resolved Hide resolved
}
else
{
targetRanges = await cosmosQueryContext.QueryClient.GetTargetPartitionKeyRangesAsync(
cosmosQueryContext.ResourceLink,
containerQueryProperties.ResourceId,
new List<Documents.Routing.Range<string>> { FeedRangeEpk.FullRange.Range },
akotalwar marked this conversation as resolved.
Show resolved Hide resolved
forceRefresh: false,
trace);
akotalwar marked this conversation as resolved.
Show resolved Hide resolved
}
}
akotalwar marked this conversation as resolved.
Show resolved Hide resolved

if (targetRanges.Count == 1)
Expand Down
Loading