-
Notifications
You must be signed in to change notification settings - Fork 524
Query: Fixes LINQ to use custom serializer to serialize constant values in Query #3406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ealsur
merged 17 commits into
master
from
users/leminh/GetItemLinqQuerableSerializerFix
Oct 13, 2022
Merged
Query: Fixes LINQ to use custom serializer to serialize constant values in Query #3406
ealsur
merged 17 commits into
master
from
users/leminh/GetItemLinqQuerableSerializerFix
Oct 13, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khdang
reviewed
Aug 25, 2022
Microsoft.Azure.Cosmos/src/SqlObjects/SqlObjectCreateScalarExpression.cs
Outdated
Show resolved
Hide resolved
adityasa
reviewed
Sep 14, 2022
...os/tests/Microsoft.Azure.Cosmos.EmulatorTests/LinqTranslationWithCustomSerializerBaseline.cs
Outdated
Show resolved
Hide resolved
adityasa
reviewed
Sep 14, 2022
...os/tests/Microsoft.Azure.Cosmos.EmulatorTests/LinqTranslationWithCustomSerializerBaseline.cs
Show resolved
Hide resolved
adityasa
reviewed
Sep 14, 2022
...os/tests/Microsoft.Azure.Cosmos.EmulatorTests/LinqTranslationWithCustomSerializerBaseline.cs
Outdated
Show resolved
Hide resolved
adityasa
reviewed
Sep 14, 2022
...os/tests/Microsoft.Azure.Cosmos.EmulatorTests/LinqTranslationWithCustomSerializerBaseline.cs
Outdated
Show resolved
Hide resolved
adityasa
reviewed
Sep 19, 2022
...os/tests/Microsoft.Azure.Cosmos.EmulatorTests/LinqTranslationWithCustomSerializerBaseline.cs
Show resolved
Hide resolved
adityasa
reviewed
Sep 19, 2022
...os/tests/Microsoft.Azure.Cosmos.EmulatorTests/LinqTranslationWithCustomSerializerBaseline.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
Sep 30, 2022
sboshra
previously approved these changes
Sep 30, 2022
Contributor
sboshra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
…://github.com/Azure/azure-cosmos-dotnet-v3 into users/leminh/GetItemLinqQuerableSerializerFix
sboshra
previously approved these changes
Oct 10, 2022
adityasa
previously approved these changes
Oct 10, 2022
Contributor
adityasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
sboshra
previously approved these changes
Oct 11, 2022
Microsoft.Azure.Cosmos/src/Serializer/CosmosLinqSerializerOptions.cs
Outdated
Show resolved
Hide resolved
sboshra
approved these changes
Oct 11, 2022
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ealsur
previously approved these changes
Oct 12, 2022
Microsoft.Azure.Cosmos/src/Serializer/CosmosLinqSerializerOptions.cs
Outdated
Show resolved
Hide resolved
sboshra
previously approved these changes
Oct 12, 2022
adityasa
approved these changes
Oct 13, 2022
Contributor
adityasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
ealsur
approved these changes
Oct 13, 2022
leminh98
pushed a commit
that referenced
this pull request
Mar 8, 2023
This was referenced Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This fix takes into account of custom serializer defined by users in CosmosClientOptions to serialize constant values during translation for LINQ queries.
Given an object:
which uses the System.Net.Json property attribute and custom System.Net.Json serializer
Consider the following query:
query = testContainer.GetItemLinqQueryable<MyItem>().Where(i => i == new MyItem() { ProjectId = "test", Id = "id1"});before this fix, it would be translated to
{"query":"SELECT VALUE root FROM root WHERE (root = {\"Id\": \"id1\", \"ProjectId\": \"test\"})"}which does not take into account of the custom serializer handling of the property attributes
After this fix, this would be correctly translated to
{"query":"SELECT VALUE root FROM root WHERE (root = {\"id\": \"id1\", \"project_id\": \"test\"})"}Type of change
Closing issues
Closes #3207