Change Feed Processor: Fixes LeaseLostException leaks on notification APIs #3401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were 3 conditions on which the Notification APIs were surfacing
LeaseLostExceptionto the user:This PR makes it so the notification APIs are called but with the InnerException related to the CosmosException (a NotFound, or a Conflict, or a PreconditionFailed error) instead of the LeaseLostException.
This way we avoid leaking the internal type but we don't miss notifying the problem.
Type of change
Please delete options that are not relevant.
Closing issues
Closes #3379