Fix: Add default route on delegatedNIC interface #3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulyufan2
requested review from
timraymond,
kmurudi and
tamilmani1989
and removed request for
timraymond
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
paulyufan2
force-pushed
the
addDefaultRouteonCNS
branch
from
0e3e209
to
97a3acd
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
paulyufan2
force-pushed
the
addDefaultRouteonCNS
branch
from
97a3acd
to
ddbec3c
Compare
aggarwal0009
previously approved these changes
Nov 7, 2024
paulyufan2
force-pushed
the
addDefaultRouteonCNS
branch
from
ddbec3c
to
603d29f
Compare
paulyufan2
force-pushed
the
addDefaultRouteonCNS
branch
from
603d29f
to
9b1925a
Compare
paulyufan2
force-pushed
the
addDefaultRouteonCNS
branch
from
4eec043
to
d669910
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kmurudi
previously approved these changes
Nov 11, 2024
paulyufan2
force-pushed
the
addDefaultRouteonCNS
branch
from
4d0bfd2
to
9b29642
Compare
isaac-dasan
previously approved these changes
Nov 12, 2024
paulyufan2
force-pushed
the
addDefaultRouteonCNS
branch
from
4b51dd6
to
3ea7872
Compare
paulyufan2
force-pushed
the
addDefaultRouteonCNS
branch
from
3ea7872
to
77aa649
Compare
rbtr
previously approved these changes
Nov 12, 2024
Co-authored-by: Evan Baker <[email protected]> Signed-off-by: Paul Yu <[email protected]>
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rbtr
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR is to fix one issue in swiftv2 Windows scenario:
When a pod is created, the default route is added on infra vnet:
root@swiftv2-pod-3:/# ip route
default via 10.244.2.1 dev eth0 metric 1
It leads to ping a VM IP in the same VNET that cannot work.
There are two issues::
1.CNS does not provide the default route to CNI;
2.CNI should only add the default route to secondary interface customer vnet; on Swiftv2 scenario, skipDefaultRoutes is set to true for infraNIC interface and false for a secondary interface; so if !info.skipDefaultRoutes, then add default route.
Add dummy default route and pass to CNI as a workaround;
After this fix after a pod creation is done, the route table shows:
root@swiftv2-pod-1:/# ip route
default via 10.241.0.1 dev eth1
10.241.0.0/16 dev eth1 proto kernel scope link src 10.241.0.55
10.244.0.0/16 dev eth0 proto kernel scope link src 10.244.1.103
Issue Fixed:
Requirements:
Notes: