feat: support for cilium + nodesubnet #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santhoshmprabhu
added
work-in-progress
cns
…-container-networking into sanprabhu/cilium-node-subnet
santhoshmprabhu
requested review from
tamilmani1989,
jpayne3506,
rbtr,
timraymond and
vipul-21
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vipul-21
reviewed
Oct 22, 2024
.pipelines/singletenancy/cilium-nodesubnet/cilium-nodesubnet-e2e-step-template.yaml
Outdated
Show resolved
Hide resolved
timraymond
reviewed
Oct 22, 2024
Co-authored-by: Timothy J. Raymond <[email protected]> Signed-off-by: Santhosh Prabhu <[email protected]>
Co-authored-by: Timothy J. Raymond <[email protected]> Signed-off-by: Santhosh Prabhu <[email protected]>
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…-container-networking into sanprabhu/cilium-node-subnet
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
LGTM. Delegating approval to others with outstanding comments. |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tamilmani1989
approved these changes
Nov 1, 2024
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
behzad-mir
approved these changes
Nov 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR completes the implementation of CNS support for nodesubnet, so that we may use Cilium with nodesubnet. This PR includes the following changes:
The changes have been validated with E2E runs, though the pipeline changes are to be merged in a separate PR (#3083).
Issue Fixed:
Cilium nodesubnet support
Requirements:
Notes: