-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add uts for cni add function #3069
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpayne3506
reviewed
Oct 15, 2024
jpayne3506
approved these changes
Oct 15, 2024
paulyufan2
approved these changes
Oct 15, 2024
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adds unit tests to test that endpoint info struct creation is as expected based on args, cns/ipam invoker response, and network configuration for the following scenarios:
Each scenario tests the
Add
method from ipam response until we call anEndpointCreate
, given args, ipam response, and network configuration and ensure the endpoint info struct generated exactly matches what is expected (so all fields are checked) except for the interface name and endpoint id as they are nondeterministic identifiers generated during runtime.Adds a check to ensure each endpoint info's Option and Data fields are separate.
Adds a check to ensure swiftv2 linux's endpoint info interface name is overwritten with the correct interface name.
Issue Fixed:
Requirements:
Notes:
This does not add tests for swiftv2 ib. It also does not explicitly add tests for swiftv1 non multitenancy scenarios as they are mostly covered by the multitenancy ones (singletenancy is just a single ipam response). This does not test anything that happens inside
EndpointCreate
.