Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add --kubernetes-version to linux-cniv1-up cluster creation #2952

Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix: Add --kubernetes-version to linux-cniv1-up cluster creation #2952

merged 1 commit into from
Aug 23, 2024

Conversation

jpayne3506
Copy link
Contributor

@jpayne3506 jpayne3506 commented Aug 22, 2024 •
edited
Loading

Reason for Change:

Fixes E2E cluster creation for CNIv1 Linux.

Changes are already contained within #2939 for 1.4 release train. This only needs to be backported to 1.5.

Issue Fixed:

Requirements:

Notes:

@jpayne3506 jpayne3506 added fix Fixes something. ci Infra or tooling. release/latest Change affects latest release train needs-backport Change needs to be backported to previous release trains release/1.5 Change affects v1.5 release train labels Aug 22, 2024
@jpayne3506 jpayne3506 self-assigned this Aug 22, 2024
@jpayne3506 jpayne3506 requested a review from a team as a code owner August 22, 2024 21:35
@jpayne3506
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jpayne3506 jpayne3506 changed the title fix: Add--kubernetes-version to linux-cniv1-up cluster creation fix: Add --kubernetes-version to linux-cniv1-up cluster creation Aug 22, 2024
QxBytes
QxBytes approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@QxBytes QxBytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have this option on the other clusters this should be fine.

@jpayne3506 jpayne3506 added this pull request to the merge queue Aug 22, 2024
Merged via the queue into master with commit cf8fb62 Aug 23, 2024
11 checks passed
@jpayne3506 jpayne3506 deleted the jpayne3506/linux-aks branch August 23, 2024 00:53
jpayne3506 added a commit that referenced this pull request Nov 12, 2024
@jpayne3506
fix: Add --kubernetes-version to linux-cniv1-up cluster creation (#2952)
87cc8bd 
fix: Add--kubernetes-version to linux-cniv1-up cluster creation
@jpayne3506 jpayne3506 mentioned this pull request Nov 12, 2024
Merged
4 tasks
@jpayne3506 jpayne3506 removed the needs-backport Change needs to be backported to previous release trains label Nov 12, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 13, 2024
@jpayne3506
[backport] fix: Add --kubernetes-version to linux-cniv1-up cluster cr…
13922b1 
…eation (#2952) (#3139)

fix: Add --kubernetes-version to linux-cniv1-up cluster creation (#2952)

fix: Add--kubernetes-version to linux-cniv1-up cluster creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QxBytes QxBytes QxBytes approved these changes

@huntergregory huntergregory Awaiting requested review from huntergregory huntergregory is a code owner automatically assigned from Azure/azure-sdn-members

Assignees

@jpayne3506 jpayne3506

Labels
ci Infra or tooling. fix Fixes something. release/latest Change affects latest release train release/1.5 Change affects v1.5 release train
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpayne3506 @QxBytes