fix: move bufio reader creation out of for loop to fix telemetry unmarshal errors #2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the bufio reader is created in the for loop we get unmarshaling errors
a previous fix ensured the socket closed on error, but this caused an existing ut to nondeterministically fail without the previous fix, the socket wouldn't have been closed on error
rbtr
reviewed
Jun 17, 2024
rbtr
approved these changes
Jun 20, 2024
QxBytes
added a commit
that referenced
this pull request
Jun 25, 2024
…rshal errors (#2789) * move bufio reader creation out of for loop if the bufio reader is created in the for loop we get unmarshaling errors * fix linter issue * add fixed ut * fix existing unit test flake due to closing pipe on error a previous fix ensured the socket closed on error, but this caused an existing ut to nondeterministically fail without the previous fix, the socket wouldn't have been closed on error * make read inline
QxBytes
added a commit
that referenced
this pull request
Jun 25, 2024
…rshal errors (#2789) * move bufio reader creation out of for loop if the bufio reader is created in the for loop we get unmarshaling errors * fix linter issue * add fixed ut * fix existing unit test flake due to closing pipe on error a previous fix ensured the socket closed on error, but this caused an existing ut to nondeterministically fail without the previous fix, the socket wouldn't have been closed on error * make read inline
QxBytes
added a commit
that referenced
this pull request
Jun 25, 2024
…rshal errors (#2789) * move bufio reader creation out of for loop if the bufio reader is created in the for loop we get unmarshaling errors * fix linter issue * add fixed ut * fix existing unit test flake due to closing pipe on error a previous fix ensured the socket closed on error, but this caused an existing ut to nondeterministically fail without the previous fix, the socket wouldn't have been closed on error * make read inline
QxBytes
added a commit
that referenced
this pull request
Jun 25, 2024
…metry unmarshal errors (#2789) (#2813) fix: move bufio reader creation out of for loop to fix telemetry unmarshal errors (#2789) * move bufio reader creation out of for loop if the bufio reader is created in the for loop we get unmarshaling errors * fix linter issue * add fixed ut * fix existing unit test flake due to closing pipe on error a previous fix ensured the socket closed on error, but this caused an existing ut to nondeterministically fail without the previous fix, the socket wouldn't have been closed on error * make read inline
QxBytes
added a commit
that referenced
this pull request
Jun 26, 2024
…rshal errors (#2789) * move bufio reader creation out of for loop if the bufio reader is created in the for loop we get unmarshaling errors * fix linter issue * add fixed ut * fix existing unit test flake due to closing pipe on error a previous fix ensured the socket closed on error, but this caused an existing ut to nondeterministically fail without the previous fix, the socket wouldn't have been closed on error * make read inline
QxBytes
added a commit
that referenced
this pull request
Jun 26, 2024
…metry unmarshal errors (#2789) (#2812) * fix: move bufio reader creation out of for loop to fix telemetry unmarshal errors (#2789) * move bufio reader creation out of for loop if the bufio reader is created in the for loop we get unmarshaling errors * fix linter issue * add fixed ut * fix existing unit test flake due to closing pipe on error a previous fix ensured the socket closed on error, but this caused an existing ut to nondeterministically fail without the previous fix, the socket wouldn't have been closed on error * make read inline * make ut compatible with 1.4.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the bufio reader is created in the for loop that handles reads we get unmarshaling errors. Creating a single bufio reader outside of the for loop once the connection is accepted and then repeatedly looping over that single reader fixes this issue.
Reason for Change:
See above
Issue Fixed:
Requirements:
Notes: