Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: build ipv6-hp-bpf in pipeline #2769

Merged
merged 9 commits into from
Jun 11, 2024
Merged

ci: build ipv6-hp-bpf in pipeline #2769

merged 9 commits into from
Jun 11, 2024

Conversation

camrynl
Copy link
Contributor

@camrynl camrynl commented Jun 5, 2024 •
edited
Loading

Reason for Change:

  • Building linux binaries and images for ipv6-hp-bpf in preparation for image release.
  • Adding cilium dual stack daemonset to run clusters with new initcontainer in pipelines

Testing Done:

  • locally run make ipv6-hp-bpf-image, make ipv6-hp-bpf-binary, make ipv6-hp-bpf-lib, make ipv6-hp-image-push, make-ipv6-hp-image-pull
  • testing in ACN PR pipeline:
    • binaries and images are built for both amd64 and arm64, artifacts are present
    • image is pushed to acnpublic
    • pipeline dual-stack cluster has ipv6-hp-bpf initcontainer and logs show program execution

Issue Fixed:

Requirements:

Notes:

@camrynl camrynl added the ci Infra or tooling. label Jun 5, 2024
@camrynl camrynl requested a review from a team as a code owner June 5, 2024 17:27
tamilmani1989
tamilmani1989 reviewed Jun 5, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
anubhabMajumdar
anubhabMajumdar reviewed Jun 5, 2024
View reviewed changes
bpf-prog/ipv6-hp-bpf/linux-arm64.Dockerfile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
anubhabMajumdar
anubhabMajumdar reviewed Jun 7, 2024
View reviewed changes
Copy link

@anubhabMajumdar anubhabMajumdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add Testing Done section in description? Can you pull without os/arch tag?

bpf-prog/ipv6-hp-bpf/linux.Dockerfile Outdated Show resolved Hide resolved
bpf-prog/ipv6-hp-bpf/linux.Dockerfile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
anubhabMajumdar
anubhabMajumdar approved these changes Jun 10, 2024
View reviewed changes
Copy link

@anubhabMajumdar anubhabMajumdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@camrynl camrynl added this pull request to the merge queue Jun 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 11, 2024
@camrynl camrynl added this pull request to the merge queue Jun 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 11, 2024
@camrynl camrynl added this pull request to the merge queue Jun 11, 2024
Merged via the queue into master with commit aa2577f Jun 11, 2024
92 checks passed
@camrynl camrynl deleted the camrynl/bpfimgpipeline branch June 11, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vakalapa vakalapa vakalapa left review comments

@anubhabMajumdar anubhabMajumdar anubhabMajumdar approved these changes

@tamilmani1989 tamilmani1989 tamilmani1989 approved these changes

@jpayne3506 jpayne3506 Awaiting requested review from jpayne3506

Assignees
No one assigned
Labels
ci Infra or tooling.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@camrynl @tamilmani1989 @vakalapa @anubhabMajumdar