Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mTLS to CNS #2751

Merged
merged 14 commits into from
Jun 8, 2024
Merged

feat: add mTLS to CNS #2751

merged 14 commits into from
Jun 8, 2024

Conversation

jackieluc
Copy link
Member

Reason for Change:

Enable mTLS support for CNS

Issue Fixed:

Requirements:

Notes:

@jackieluc jackieluc added the cns Related to CNS. label May 24, 2024
@jackieluc jackieluc requested review from a team as code owners May 24, 2024 20:41
@jackieluc
Copy link
Member Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

ZetaoZhuang
ZetaoZhuang reviewed May 28, 2024
View reviewed changes
cns/service.go Outdated Show resolved Hide resolved
@rbtr rbtr requested a review from paulyufan2 May 30, 2024 17:19
@paulyufan2
Copy link
Contributor

can we add the description to the PR?

paulyufan2
paulyufan2 reviewed May 30, 2024
View reviewed changes
cns/service.go Outdated Show resolved Hide resolved
cns/service.go Show resolved Hide resolved
paulyufan2
paulyufan2 reviewed May 30, 2024
View reviewed changes
cns/service.go Outdated Show resolved Hide resolved
@jackieluc
Copy link
Member Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

paulyufan2
paulyufan2 previously approved these changes May 31, 2024
View reviewed changes
@jackieluc
Copy link
Member Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jackieluc
Copy link
Member Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

paulyufan2
paulyufan2 previously approved these changes Jun 7, 2024
View reviewed changes
rbtr
rbtr requested changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests comment is non-blocking, but I think that redundant struct field should be removed

common/listener.go Outdated Show resolved Hide resolved
cns/service_test.go Outdated Show resolved Hide resolved
@jackieluc
Copy link
Member Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jackieluc jackieluc added this pull request to the merge queue Jun 7, 2024
Merged via the queue into Azure:master with commit de225e4 Jun 8, 2024
11 checks passed
@jackieluc jackieluc deleted the mtls branch June 8, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZetaoZhuang ZetaoZhuang ZetaoZhuang left review comments

@msvik msvik msvik approved these changes

@rbtr rbtr rbtr approved these changes

@paulyufan2 paulyufan2 paulyufan2 left review comments

@ashvindeodhar ashvindeodhar Awaiting requested review from ashvindeodhar ashvindeodhar is a code owner automatically assigned from Azure/acn-cns-reviewers

Assignees
No one assigned
Labels
cns Related to CNS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jackieluc @paulyufan2 @rbtr @msvik @ZetaoZhuang