Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Change ACR Service Connection #2727

Merged
merged 1 commit into from
May 8, 2024
Merged

ci: Change ACR Service Connection #2727

merged 1 commit into from
May 8, 2024

Conversation

jpayne3506
Copy link
Contributor

@jpayne3506 jpayne3506 commented May 3, 2024

Reason for Change:

Going from docker registry service connection to ARM service connection requires the use of AZ CLI task.

Added variable to change image repository.

Issue Fixed:

Requirements:

Notes:
Impacts

  • NPM Conformance Tests
  • ACN PR
  • Cilium Nightly
  • NPM Scale Test

@jpayne3506 jpayne3506 self-assigned this May 3, 2024
@jpayne3506 jpayne3506 requested a review from a team as a code owner May 3, 2024 19:40
@jpayne3506 jpayne3506 added the ci Infra or tooling. label May 3, 2024
@jpayne3506 jpayne3506 added this pull request to the merge queue May 7, 2024
Merged via the queue into master with commit be88049 May 8, 2024
93 checks passed
@jpayne3506 jpayne3506 deleted the jpayne3506/acrMI branch May 8, 2024 01:47
@jpayne3506 jpayne3506 added the needs-backport Change needs to be backported to previous release trains label Jun 25, 2024
jpayne3506 added a commit that referenced this pull request Jun 25, 2024
jpayne3506 added a commit that referenced this pull request Jun 26, 2024
* ci: Change ACR Service Connection (#2727)

* fix: pin Windows images (#2742)

Signed-off-by: Evan Baker <[email protected]>

* ci: [WIN-NPM] remove ws19 build (#1844)

* remove NPM build for ws19

* set OS versions by variable in manifest-build

---------

Co-authored-by: Vamsi Kalapala <[email protected]>

---------

Signed-off-by: Evan Baker <[email protected]>
Co-authored-by: Evan Baker <[email protected]>
Co-authored-by: Hunter Gregory <[email protected]>
Co-authored-by: Vamsi Kalapala <[email protected]>
QxBytes pushed a commit that referenced this pull request Aug 7, 2024
@jpayne3506 jpayne3506 added release/1.4 Change affects v1.4 release train release/latest Change affects latest release train and removed needs-backport Change needs to be backported to previous release trains labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Infra or tooling. release/latest Change affects latest release train release/1.4 Change affects v1.4 release train
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants