feat: update CRDs to accomodate multiple pod nics #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
estebancams
reviewed
Apr 29, 2024
kmurudi
reviewed
May 2, 2024
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
crd/multitenancy/manifests/multitenancy.acn.azure.com_podnetworkinstances.yaml
Show resolved
Hide resolved
estebancams
reviewed
May 2, 2024
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
estebancams
approved these changes
May 2, 2024
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kmurudi
reviewed
May 20, 2024
| GatewayIP string `json:"gatewayIP,omitempty"` | ||
| // InterfaceInfos describes all of the network container goal state for this Pod | ||
| // +kubebuilder:validation:Optional | ||
| InterfaceInfos []InterfaceInfo `json:"interfaceInfos,omitempty"` |
There was a problem hiding this comment.
this will be populated then ignore higher fields in mtpncStatus
kmurudi
reviewed
May 20, 2024
| // MultitenantPodNetworkConfigStatus defines the observed state of PodNetworkConfig | ||
| type MultitenantPodNetworkConfigStatus struct { | ||
| // network container id | ||
| // Deprecated - use InterfaceInfos | ||
| // +kubebuilder:validation:Optional | ||
| NCID string `json:"ncID,omitempty"` |
There was a problem hiding this comment.
these will be populated only for delegatedVMNIC (vnet nic & non-accelnet) if len(InterfaceInfos[]) is empty then only read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Updates the multitenancy CRD schemas to support multiple Pod NICs
Requirements:
Notes: