Feat: Added ETW logging support for CNS. #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timraymond
reviewed
Apr 23, 2024
rbtr
requested changes
Apr 23, 2024
Co-authored-by: Evan Baker <[email protected]> Signed-off-by: sivakami-projects <[email protected]>
Co-authored-by: Evan Baker <[email protected]> Signed-off-by: sivakami-projects <[email protected]>
Co-authored-by: Evan Baker <[email protected]> Signed-off-by: sivakami-projects <[email protected]>
…gs added to ensure zap instance is not nil.
rbtr
reviewed
Apr 23, 2024
rbtr
approved these changes
Apr 24, 2024
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
paulyufan2
pushed a commit
that referenced
this pull request
Apr 29, 2024
* Added ETW logging support for CNS. * Renamed unused parameter. Removed punctuation mark from error message. * Added flag to write logs to ETW. Zap logger writes only to ETW in windows. And is NIL in Linux. * Enable ETW logging in CNS through config. * Provide flexibility on zap logging format. * renamed zap logger instance. * Renamed method. * Update cns/logger/cnslogger_windows.go Co-authored-by: Evan Baker <[email protected]> Signed-off-by: sivakami-projects <[email protected]> * Update cns/logger/cnslogger_linux.go Co-authored-by: Evan Baker <[email protected]> Signed-off-by: sivakami-projects <[email protected]> * Use Nop core until zap is implemented for all the logs in CNS. Co-authored-by: Evan Baker <[email protected]> Signed-off-by: sivakami-projects <[email protected]> * return Nopcore for Linux until zap is fully implmemented. Removed flags added to ensure zap instance is not nil. * cganged method name. * Moved zap logger intilization in cnslogger file. Code polishes. --------- Signed-off-by: sivakami-projects <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Evan Baker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: