Skip to content

fix: lint vs release branch instead of master #2352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix: lint vs release branch instead of master #2352

merged 1 commit into from
Jan 18, 2024

Conversation

rbtr
Copy link
Contributor

@rbtr rbtr commented Nov 3, 2023

Reason for Change:

Issue Fixed:

Requirements:

Notes:

@nddq nddq force-pushed the v1.4/fix/branch-ref branch from cb0cd28 to 84ff627 Compare November 5, 2023 04:31
@rbtr rbtr force-pushed the v1.4/fix/branch-ref branch from 84ff627 to 4cffbf9 Compare December 15, 2023 17:13
@rbtr rbtr enabled auto-merge (squash) December 15, 2023 17:13
@github-actions github-actions bot added the stale Stale due to inactivity. label Dec 30, 2023
@rbtr rbtr removed the stale Stale due to inactivity. label Jan 2, 2024
@Azure Azure deleted a comment from github-actions bot Jan 4, 2024
@rbtr rbtr self-assigned this Jan 4, 2024
@rbtr rbtr added ci Infra or tooling. release/1.4 Change affects v1.4 release train labels Jan 4, 2024
@rbtr rbtr force-pushed the v1.4/fix/branch-ref branch from 4cffbf9 to 36ab890 Compare January 17, 2024 15:51
jpayne3506
jpayne3506 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@jpayne3506 jpayne3506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran locally and intended changes occurred to the make command. Does this also need to impact the GH workflow?

@rbtr
Copy link
Contributor Author

rbtr commented Jan 17, 2024

Ran locally and intended changes occurred to the make command. Does this also need to impact the GH workflow?

the Action already uses the correct target branch

@rbtr rbtr merged commit 203b59c into release/v1.4 Jan 18, 2024
@rbtr rbtr deleted the v1.4/fix/branch-ref branch January 18, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpayne3506 jpayne3506 jpayne3506 approved these changes

Assignees

@rbtr rbtr

Labels
ci Infra or tooling. release/1.4 Change affects v1.4 release train
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbtr @jpayne3506