Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: validate secondary endpoint client failure #2345

Merged
merged 3 commits into from
Nov 3, 2023
Merged

test: validate secondary endpoint client failure #2345

merged 3 commits into from
Nov 3, 2023

Conversation

jaer-tsun
Copy link
Contributor

@jaer-tsun jaer-tsun commented Nov 2, 2023 •
edited
Loading

Reason for Change:
Add a test to validate that endpoint will not be created if SecondaryEndpointClient fails

Passing NIC Type var from CNS response down instead of hardcoding

Issue Fixed:

Requirements:

Notes:

@jaer-tsun jaer-tsun requested review from a team as code owners November 2, 2023 16:46
@jaer-tsun jaer-tsun force-pushed the testSecondaryEndpointClientFailure branch 2 times, most recently from 584083e to 6ef7dd0 Compare November 2, 2023 17:35
vipul-21
vipul-21 reviewed Nov 2, 2023
View reviewed changes
network/endpoint_test.go Outdated Show resolved Hide resolved
vipul-21
vipul-21 previously approved these changes Nov 2, 2023
View reviewed changes
@jaer-tsun jaer-tsun force-pushed the testSecondaryEndpointClientFailure branch from 6ef7dd0 to ad6439c Compare November 3, 2023 15:08
@jaer-tsun jaer-tsun enabled auto-merge (squash) November 3, 2023 15:15
vipul-21
vipul-21 previously approved these changes Nov 3, 2023
View reviewed changes
nddq
nddq requested changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@nddq nddq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit comment on the UT, just wondering, will the secondary endpoint client failed only on bad MAC address, or would there be other scenarios that could cause this failure also?

network/endpoint_test.go Show resolved Hide resolved
@jaer-tsun jaer-tsun merged commit 4168c62 into master Nov 3, 2023
86 checks passed
@jaer-tsun jaer-tsun deleted the testSecondaryEndpointClientFailure branch November 3, 2023 23:32
matmerr pushed a commit that referenced this pull request Jan 17, 2024
@jaer-tsun @matmerr
test: validate secondary endpoint client failure (#2345)
b681f27 
test: validate secondary endpoint client failure will prevent endpoint creation

Co-authored-by: Jaeryn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nddq nddq nddq approved these changes

@vipul-21 vipul-21 vipul-21 approved these changes

@jpayne3506 jpayne3506 Awaiting requested review from jpayne3506 jpayne3506 is a code owner automatically assigned from Azure/acn-cni-reviewers

Assignees
No one assigned
Labels
swift-v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaer-tsun @vipul-21 @nddq