feat: cni refactor for swift v2 #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jaer-tsun
force-pushed
the
cniSwift2
branch
2 times, most recently
from
28f8d9f
to
c15a2aa
Compare
behzad-mir
reviewed
Oct 30, 2023
cni/network/invoker_azure_test.go
Outdated
| wantErr bool | ||
| }{ | ||
| { | ||
| name: "happy add ipv4", | ||
| fields: fields{ | ||
| plugin: &mockDelegatePlugin{ | ||
| add: add{ | ||
| resultsIPv4: getResult("10.0.0.1/24"), | ||
| resultsIPv4: getSingleResult("10.0.0.1/24"), |
There was a problem hiding this comment.
Can you move the subnet to a var at the beginning of the file?
cni/network/invoker_azure_test.go
Outdated
| @@ -145,16 +152,16 @@ func TestAzureIPAMInvoker_Add(t *testing.T) { | |||
| nwCfg: &cni.NetworkConfig{}, | |||
| subnetPrefix: getCIDRNotationForAddress("10.0.0.0/24"), | |||
| }, | |||
| want: getResult("10.0.0.1/24")[0], | |||
| want: getResult("10.0.0.1/24"), | |||
| errInvalidDefaultRouting = errors.New("add result requires exactly one interface with default routes") | ||
| errInvalidGatewayIP = errors.New("invalid gateway IP") | ||
| overlayGatewayV6IP = "fe80::1234:5678:9abc" | ||
| watcherPath = "/var/run/azure-vnet/deleteIDs" |
There was a problem hiding this comment.
Do we need a path for Windows?
There was a problem hiding this comment.
not supported atm
vipul-21
reviewed
Oct 30, 2023
|
@jaer-tsun can we also validate this commit with release pipelines.. check with @jpayne3506 on this |
|
/azp run CNI Load Test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run CNI Load Test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 12 commits
November 1, 2023 15:18
added 22 commits
November 1, 2023 15:18
tamilmani1989
approved these changes
Nov 1, 2023
vipul-21
approved these changes
Nov 1, 2023
jpayne3506
approved these changes
Nov 1, 2023
behzad-mir
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combining 4 CNI PRs from forked repo
Reason for Change:
CNI changes for Swift 2
Issue Fixed:
Requirements:
Notes: