Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CNI async delete to old API for cilium #2302

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Adding CNI async delete to old API for cilium #2302

merged 1 commit into from
Oct 20, 2023

Conversation

rjdenney
Copy link
Contributor

@rjdenney rjdenney commented Oct 18, 2023 •
edited
Loading

Reason for Change:

In case we use ReleaseIPAddress instead of ReleaseIPs we need to add a second check for async delete.

Was originally a part of #2239 but the change was separated out.

Issue Fixed:

Requirements:

Notes:

@rjdenney rjdenney requested a review from a team as a code owner October 18, 2023 16:34
@rjdenney rjdenney assigned camrynl and unassigned camrynl Oct 18, 2023
@camrynl camrynl requested a review from nddq October 18, 2023 16:49
@rjdenney rjdenney enabled auto-merge (squash) October 18, 2023 19:23
@rjdenney rjdenney force-pushed the asyncDeleteOldApi branch 2 times, most recently from 3fc9e70 to 5c60166 Compare October 19, 2023 21:06
@rjdenney rjdenney merged commit e6bc6da into master Oct 20, 2023
78 checks passed
@rjdenney rjdenney deleted the asyncDeleteOldApi branch October 20, 2023 00:03
camrynl added a commit that referenced this pull request Nov 2, 2023
@camrynl
Revert "Adding CNI async delete to old API for cilium (#2302)"
1811150 
This reverts commit e6bc6da.
camrynl added a commit that referenced this pull request Nov 3, 2023
@camrynl
Revert "Adding CNI async delete to old API for cilium (#2302)"
47faec2 
This reverts commit e6bc6da.
tamilmani1989 pushed a commit that referenced this pull request Nov 3, 2023
@camrynl
revert: async delete changes for azure-ipam (#2346)
5b9aaef 
* Revert "Adding CNI async delete to old API for cilium (#2302)"

This reverts commit e6bc6da.

* remove previous changes for async delete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camrynl camrynl camrynl approved these changes

@nddq nddq nddq approved these changes

@ZetaoZhuang ZetaoZhuang Awaiting requested review from ZetaoZhuang ZetaoZhuang is a code owner automatically assigned from Azure/azure-sdn-members

@tamilmani1989 tamilmani1989 Awaiting requested review from tamilmani1989

Assignees
No one assigned
Labels
azure-ipam
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjdenney @nddq @camrynl