fix: assume invalid semver CNI has the required dump state command #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alam-tahmid
approved these changes
Jul 26, 2023
nairashu
approved these changes
Jul 26, 2023
thatmattlong
added a commit
that referenced
this pull request
Jul 27, 2023
4 tasks
thatmattlong
added a commit
that referenced
this pull request
Jul 31, 2023
* fix: assume invalid semver CNI has the required dump state command (#2078) * fix: Updating the vmsize for e2e cilium to avoid resource scarcity (#2014) CI: Testing the e2e test for cilium --------- Co-authored-by: Vipul Singh <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The CNS will invoke CNI's
versioncommand to check CNI version, and use it to determine whether it can be used for reconciling CNS state. This is achieved by a semver comparison >= v1.4.7. However, if the CNI was not tagged with a semantic version, this fails. Since CNI v1.4.7 is quite old, it is probably safe to remove this check entirely and just say "CNS >= v1.4.44 can't be used with CNI <=v1.4.6", but for now we'll just ignore the sem ver check if the parsing fails and assume we can use the command.Requirements:
Notes:
I'm open to just removing the semver check altogether with the caveat that CNS v1.4.44 and above must be used with CNI >= v1.4.7.