fix: skip reserved IPs #2060
Merged
fix: skip reserved IPs #2060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
previously approved these changes
Jul 14, 2023
cns/kubecontroller/nodenetworkconfig/conversion_windows_test.go
Outdated
Show resolved
Hide resolved
jaer-tsun
force-pushed
the
tsch/skipReservedIPs
branch
3 times, most recently
from
af70959 to
ce76762
Compare
thatmattlong
approved these changes
Jul 14, 2023
jaer-tsun
force-pushed
the
tsch/skipReservedIPs
branch
from
ce76762 to
778bace
Compare
neaggarwMS
reviewed
Jul 17, 2023
| // as secondary IPs | ||
| startingAddr := primaryIPPrefix.Masked().Addr() // the masked address is the 0th IP in the subnet | ||
| // the masked address is the 0th IP in the subnet and startingAddr is the 2nd IP (*.1) | ||
| startingAddr := primaryIPPrefix.Masked().Addr().Next() |
There was a problem hiding this comment.
We also need to reserve .255
| }, | ||
| } | ||
|
|
||
| var validVNETBlockRequest = &cns.CreateNetworkContainerRequest{ |
There was a problem hiding this comment.
can you please also add a test case for ipv6?
There was a problem hiding this comment.
we'll add later since this needs to go in for quick-fix
timraymond
reviewed
Jul 17, 2023
| @@ -35,3 +35,63 @@ var validOverlayRequest = &cns.CreateNetworkContainerRequest{ | |||
| }, | |||
| }, | |||
| } | |||
|
|
|||
| var validVNETBlockRequest = &cns.CreateNetworkContainerRequest{ | |||
There was a problem hiding this comment.
Can you inline these vars in the body of the tests that use them or turn them into factory funcs?
Despite their prevalence in ACN code, using package variables for test data is not a best practice.
jaer-tsun
added a commit
to jaer-tsun/azure-container-networking
that referenced
this pull request
Jul 17, 2023
Co-authored-by: Jaeryn <[email protected]>
jaer-tsun
added a commit
to jaer-tsun/azure-container-networking
that referenced
this pull request
Jul 17, 2023
Co-authored-by: Jaeryn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
We need to use .1 address of subnet as GW; skipping 0th and last IP of subnets since they are reserved from HNS POV
Issue Fixed:
Requirements:
Notes: