ci: validate CNS in-memory state after restart #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vipul-21
reviewed
Jul 11, 2023
| kubectl get pod -owide -A | ||
| make test-validate-state | ||
| echo "restart CNS" | ||
| kubectl rollout restart ds azure-cns -n kube-system |
There was a problem hiding this comment.
Let's add a wait as well. kubectl rollout status ds azure-cns -n kube-system to make sure azure-cns has restarted.
| @@ -165,6 +165,18 @@ steps: | |||
| name: "validatePods" | |||
| displayName: "Validate Pods" | |||
|
|
|||
| - script: | | |||
There was a problem hiding this comment.
Should we add cilium agent restarts as well ?
There was a problem hiding this comment.
I think that check can be reserved for cilium nightly pipeline runs
vipul-21
previously approved these changes
Jul 12, 2023
| @@ -165,6 +165,19 @@ steps: | |||
| name: "validatePods" | |||
| displayName: "Validate Pods" | |||
|
|
|||
| - script: | | |||
| echo "validate pod IP assignment and check systemd-networkd restart" | |||
There was a problem hiding this comment.
why log message says "systemd-networkd" restart
There was a problem hiding this comment.
The cmd make test-validate-state validates the state after restarting systemd-networkd restart for linux as a part of validating state.
rbtr
pushed a commit
that referenced
this pull request
Sep 8, 2023
* validate pod states after cns restart * update job * wait for cns to complete restart * update pipeline log * update pipeline log
jpayne3506
pushed a commit
that referenced
this pull request
Sep 11, 2023
* validate pod states after cns restart * update job * wait for cns to complete restart * update pipeline log * update pipeline log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adds check to validate CNS pod IP assignment before and after the CNS daemonset is restarted.
Issue Fixed:
Requirements:
Notes: