Skip to content

fix: disabling CGO for NPM #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2023
Merged

fix: disabling CGO for NPM #2044

merged 1 commit into from
Jul 14, 2023

Conversation

vakalapa
Copy link
Contributor

@vakalapa vakalapa commented Jul 5, 2023

Reason for Change:

Issue Fixed:

Requirements:

Notes:

@vakalapa vakalapa requested a review from a team as a code owner July 5, 2023 22:37
@vakalapa vakalapa requested a review from matmerr July 5, 2023 22:37
@tamilmani1989 tamilmani1989 added the npm Related to NPM. label Jul 11, 2023
huntergregory
huntergregory approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@huntergregory huntergregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested this for Linux & Windows. No errors in logs

@huntergregory
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s), but failed to run 1 pipeline(s).

@huntergregory huntergregory enabled auto-merge (squash) July 13, 2023 16:26
@vipul-21 vipul-21 force-pushed the vakr/cgodisablenpm branch from 3c5594a to 5b1b28b Compare July 14, 2023 00:19
@vipul-21 vipul-21 force-pushed the vakr/cgodisablenpm branch from 5b1b28b to fdfd0b3 Compare July 14, 2023 04:17
@huntergregory huntergregory merged commit e469136 into master Jul 14, 2023
@huntergregory huntergregory deleted the vakr/cgodisablenpm branch July 14, 2023 06:35
rbtr pushed a commit that referenced this pull request Sep 8, 2023
@vakalapa
fix: disabling CGO for NPM (#2044)
b3b1ed2
jpayne3506 pushed a commit that referenced this pull request Sep 11, 2023
@vakalapa @jpayne3506
fix: disabling CGO for NPM (#2044)
31aed4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huntergregory huntergregory huntergregory approved these changes

@matmerr matmerr Awaiting requested review from matmerr matmerr is a code owner automatically assigned from Azure/acn-npm-reviewers

Assignees
No one assigned
Labels
npm Related to NPM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vakalapa @huntergregory @tamilmani1989