Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CNS init must have an NC #2030

Merged
merged 1 commit into from
Jun 23, 2023
Merged

fix: CNS init must have an NC #2030

merged 1 commit into from
Jun 23, 2023

Conversation

rbtr
Copy link
Contributor

@rbtr rbtr commented Jun 22, 2023

Reason for Change:

CNS must receive an NC via the NNC to function; it is nonsensical to do anything before the NNC.NC is available. This corrects the initialization to return errors instead of potentially incorrectly initializing state.

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr requested a review from a team as a code owner June 22, 2023 22:17
@rbtr rbtr self-assigned this Jun 22, 2023
@rbtr rbtr added cns Related to CNS. swift Related to SWIFT networking. overlay Related to Overlay networking. fix Fixes something. labels Jun 22, 2023
@rbtr rbtr enabled auto-merge (squash) June 22, 2023 22:18
@rbtr rbtr merged commit c48c3e1 into Azure:master Jun 23, 2023
@rbtr rbtr deleted the fix/reconcile-no-nc branch June 23, 2023 00:47
jaer-tsun pushed a commit to jaer-tsun/azure-container-networking that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cns Related to CNS. fix Fixes something. overlay Related to Overlay networking. swift Related to SWIFT networking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants