Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix cilium validate state check for PRs #1962

Merged
merged 4 commits into from
May 17, 2023
Merged

ci: fix cilium validate state check for PRs #1962

merged 4 commits into from
May 17, 2023

Conversation

camrynl
Copy link
Contributor

@camrynl camrynl commented May 15, 2023

Reason for Change:

After restart node stage was added, the PR check to validate pods was getting skipped.

  • Updating the condition in the script to check all namespaces
  • Running the check before and after deletion of cilium-test namespace to verify the check works when endpoints change.

Issue Fixed:

Requirements:

Notes:
load test pipeline run: https://msazure.visualstudio.com/One/_build/results?buildId=73145191&view=results

@camrynl camrynl added the ci Infra or tooling. label May 15, 2023
@camrynl camrynl requested review from tamilmani1989 and vipul-21 May 15, 2023 16:42
@camrynl camrynl requested a review from a team as a code owner May 15, 2023 16:42
vipul-21
vipul-21 previously approved these changes May 15, 2023
View reviewed changes
@camrynl camrynl enabled auto-merge (squash) May 15, 2023 20:59
@camrynl camrynl requested a review from vipul-21 May 16, 2023 15:53
@camrynl camrynl force-pushed the validatestate branch 2 times, most recently from 9caf9b1 to d39328b Compare May 17, 2023 18:13
@camrynl camrynl merged commit 47a358c into master May 17, 2023
@camrynl camrynl deleted the validatestate branch May 17, 2023 22:55
jpayne3506 pushed a commit that referenced this pull request May 18, 2023
@camrynl @jpayne3506
ci: fix cilium validate state check for PRs (#1962)
4555481 
* updating validate state check

* fix cluster create

* remove makefile changes
jpayne3506 added a commit that referenced this pull request May 18, 2023
@jpayne3506
ci: Adding #1962 changes
e85400c
@jpayne3506 jpayne3506 mentioned this pull request May 18, 2023
Merged
3 tasks
@jpayne3506 jpayne3506 mentioned this pull request Jun 7, 2023
Closed
3 tasks
jpayne3506 added a commit that referenced this pull request Jun 8, 2023
@jpayne3506
ci: Adding #1962 changes
a09c57c
rbtr pushed a commit that referenced this pull request Sep 8, 2023
@camrynl
ci: fix cilium validate state check for PRs (#1962)
49b152f 
* updating validate state check

* fix cluster create

* remove makefile changes
jpayne3506 pushed a commit that referenced this pull request Sep 11, 2023
@camrynl @jpayne3506
ci: fix cilium validate state check for PRs (#1962)
acc49c7 
* updating validate state check

* fix cluster create

* remove makefile changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vipul-21 vipul-21 vipul-21 approved these changes

@tamilmani1989 tamilmani1989 Awaiting requested review from tamilmani1989

Assignees
No one assigned
Labels
ci Infra or tooling.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camrynl @vipul-21