fix: [CNI] NAT hostPort mapping for HNSv2 #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 17, 2023 11:16
vipul-21
reviewed
Apr 20, 2023
cni/network/network_windows.go
Outdated
| @@ -257,6 +257,7 @@ func getPoliciesFromRuntimeCfg(nwCfg *cni.NetworkConfig) []policy.Policy { | |||
| InternalPort: uint16(mapping.ContainerPort), | |||
| VIP: mapping.HostIp, | |||
| Protocol: protocol, | |||
| Flags: hnsv2.NatFlagsLocalRoutedVip, // iota'd, NatFlagsLocalRoutedVip = 1, uint32 | |||
There was a problem hiding this comment.
Is this a constant value ? What does this mean ? ( Just curious)
There was a problem hiding this comment.
It is a constant value set here https://github.com/microsoft/hcsshim/blob/298b31d151ab799c1d7686f8ee9eec1cb4213926/hcn/hcnpolicy.go#L82 .
Was trying to match other code snippets in cni where they match the TCP/UDP to constant values as well.
I could remove the iota'd comment and change it to // uint32 NatFlagsLocalRoutedVip = 1 if that makes it more clear.
There was a problem hiding this comment.
can you add a comment above this change saying "its to support hostport policy mapping"
added 2 commits
April 20, 2023 14:07
vipul-21
previously approved these changes
Apr 20, 2023
tamilmani1989
approved these changes
Apr 21, 2023
vipul-21
approved these changes
Apr 21, 2023
rbtr
pushed a commit
that referenced
this pull request
Sep 8, 2023
* NAT update * NAT update * Cleaning up and unit test * Fix Lint * Fix Lint * Fix Lint - Addr. comments --------- Co-authored-by: jpayne3506 <[email protected]>
jpayne3506
added a commit
that referenced
this pull request
Sep 11, 2023
* NAT update * NAT update * Cleaning up and unit test * Fix Lint * Fix Lint * Fix Lint - Addr. comments --------- Co-authored-by: jpayne3506 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Enables the use of hostport mapping with HNSv2 by setting a flag in PortMappingPolicySetting. This reflects in hnsendpoint by showing a new policy for the route which is created by the OS.
Issue Fixed:
Fixes #1863
Requirements:
Notes:
You can confirm the policy and route through the node by using
get-hnsendpoint | ? IPAddress -Like "node ip" | Convertto-json -d 16for exclusively policy use
get-hnsendpoint | ? IPAddress -Like "node ip" | Select Policies | Convertto-json -d 16Internal port / containerPort must match an already listening port on the pod. If not using the default service port 80, user will need to create and open port.