CNS writes Cilium Conflist #1901
Merged
+104
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camrynl
requested review from
rsagasthya,
tamilmani1989,
thatmattlong and
rbtr
and removed request for
a team
rbtr
previously approved these changes
Apr 7, 2023
rbtr
approved these changes
Apr 11, 2023
rbtr
force-pushed
the
writeCiliumConflist
branch
from
a80c68b to
09cd53a
Compare
thatmattlong
pushed a commit
that referenced
this pull request
May 4, 2023
* implement cilium conflist generator * add cilium conflist for generator test * update generator-windows * cleaning up generator constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Today we use dropgz as an initcontainer to bring the cilium conflist to clusters. This PR allows for CNS to write the cilium conflist instead. Dropgz will still be required to install azure-ipam. This feature already exists for the overlay scenario, and it keeps nodes in NotReady state until the network is ready. Now, CNS can write the cilium conflist if we set in the cnsconfig: EnableCNIConflistGeneration as true, specify the conflist scenario to cilium, and set the conflist filepath.
Issue Fixed:
Requirements:
Notes:
Changes were validated in byocni overlay-cilium and byocni pod subnet cilium clusters. The azure-cns deployment was modified so that dropgz only installs azure-ipam, and CNS writes the cilium conflist to etc/cni/net.d.