fix: [Telemetry] Prevent telemetry connect if no binary path #1883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
reviewed
Mar 31, 2023
tamilmani1989
requested changes
Mar 31, 2023
vipul-21
reviewed
Mar 31, 2023
rbtr
requested changes
Apr 4, 2023
vipul-21
requested changes
Apr 4, 2023
added 2 commits
April 4, 2023 18:53
vipul-21
changed the title
tamilmani1989
approved these changes
Apr 6, 2023
vipul-21
approved these changes
Apr 7, 2023
rbtr
approved these changes
Apr 7, 2023
rbtr
pushed a commit
that referenced
this pull request
Sep 8, 2023
* Prevent telemetry connect if no binary path * agnostic calls, addressing comments * agnostic calls, addressing comments * Correcting flow, lint * Restoring aiwrapper * lint error 113 cleanup * addressing comments * cleaning up telemetry folder error calls * addressing comments * addressing comments * addressing comments --------- Co-authored-by: jpayne3506 <[email protected]> Co-authored-by: tamilmani1989 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Prevents telemetry connection if the binary does not exist.
Updating errors to match with lint.
Issue Fixed:
Requirements:
Notes:
Binary is only present if CNI is starting the telemetry service. As this is being called in the CNI package we need to stop telemetry from proceeding with starting the telemetry service.