instantiate a default cns config if loading fails #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cns/service/main.go
Outdated
| @@ -503,6 +503,7 @@ func main() { | |||
| cnsconfig, err := configuration.ReadConfig(cmdLineConfigPath) | |||
| if err != nil { | |||
| logger.Errorf("[Azure CNS] Error reading cns config: %v", err) | |||
| cnsconfig = &configuration.CNSConfig{} | |||
There was a problem hiding this comment.
We should make it apparent in the error log line that a default will be used. I'm also curious if we should only use a default in cases where the file is missing. If, for example, the file is malformed, maybe it's better to still crash such that orchestrators take action.
Signed-off-by: Evan Baker <[email protected]>
Signed-off-by: Evan Baker <[email protected]>
…lformed Signed-off-by: Evan Baker <[email protected]>
ramiro-gamarra
approved these changes
Mar 2, 2023
rjdenney
pushed a commit
that referenced
this pull request
Mar 13, 2023
Signed-off-by: Evan Baker <[email protected]>
rbtr
added a commit
that referenced
this pull request
Sep 8, 2023
Signed-off-by: Evan Baker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Currently if CNS does not find a config it returns a nil pointer and an error, but does not stop executing and continues to attempt to use that nil config pointer (immediately, in the next line...).
This change modifies the behavior such that if we fail to find a config and return a nil pointer, we instantiate a default struct and assign it to make the subsequent pointer refs valid.
Issue Fixed:
closes #1775
Requirements:
Notes: