Include body for unpublishNC calls to support AZR #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smittal22
changed the title
smittal22
changed the title
ramiro-gamarra
requested changes
Mar 1, 2023
smittal22
force-pushed
the
sm-new-nc-delete-azr
branch
from
5fc6784
to
acf694c
Compare
ramiro-gamarra
approved these changes
Mar 1, 2023
rjdenney
pushed a commit
that referenced
this pull request
Mar 13, 2023
* initial delete NC changes to include body * initial delete NC changes to include body * lint error * initial delete NC changes to include body * initial delete NC changes to include body * lint error * test change * test change * add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
To enable AZR support, we need to pass two extra params
azID (uint)andenableAZR (boolean)as part of body to NMAgent. Since we are not passing body to NMAgent as of now, this PR adds a body to the request just like we have for publish NC.Whenever NC has
enableAZR = truein NC config, we will pass body like:{"azID":<value>,"enableAZR":true}For already existing NC (or if NC has
enableAZR = falsein NC config), we will pass body like:{"azID": 0,"enableAZR":false}Issue Fixed:
https://msazure.visualstudio.com/DefaultCollection/One/_workitems/edit/16187805
Requirements:
Notes: