Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade goldpinger version and increase ping/check timeout #1810

Merged
merged 5 commits into from
Feb 23, 2023
Merged

upgrade goldpinger version and increase ping/check timeout #1810

merged 5 commits into from
Feb 23, 2023

Conversation

ZetaoZhuang
Copy link
Contributor

Reason for Change:

Issue Fixed:

Requirements:

Notes:

timraymond
timraymond previously approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@timraymond timraymond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem reasonable to me 👍

@ZetaoZhuang
replace the deprecated timeout config with latest one
72084ba 
increase the check/check_all/dns timeout
timraymond
timraymond requested changes Feb 22, 2023
View reviewed changes
Copy link
Member

@timraymond timraymond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request: If these configs now allow units, it would be more obvious to readers to use seconds instead of making them do the math.

test/integration/manifests/goldpinger/daemonset.yaml Outdated Show resolved Hide resolved
test/integration/manifests/goldpinger/daemonset.yaml Outdated Show resolved Hide resolved
test/integration/manifests/goldpinger/daemonset.yaml Outdated Show resolved Hide resolved
@rbtr rbtr enabled auto-merge (squash) February 22, 2023 22:31
@rbtr rbtr merged commit 130db06 into master Feb 23, 2023
@rbtr rbtr deleted the fix_Cilium_E2E_test branch February 23, 2023 01:20
rjdenney pushed a commit that referenced this pull request Mar 13, 2023
@ZetaoZhuang @rjdenney
upgrade goldpinger version and increase ping/check timeout (#1810)
b7697c1 
* upgrade goldpinger version and increase ping/check timeout

* replace the deprecated timeout config with latest one
increase the check/check_all/dns timeout

* use straightforward unit in config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebancams estebancams estebancams approved these changes

@timraymond timraymond timraymond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZetaoZhuang @timraymond @estebancams @rbtr