Skip to content

update to go1.20 #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2023
Merged

update to go1.20 #1781

merged 1 commit into from
Mar 29, 2023

Conversation

rbtr
Copy link
Contributor

@rbtr rbtr commented Feb 2, 2023

Signed-off-by: Evan Baker [email protected]

Reason for Change:

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr requested review from a team, matmerr and vakalapa as code owners February 2, 2023 22:44
@rbtr rbtr requested review from thatmattlong and removed request for a team February 2, 2023 22:44
@rbtr rbtr self-assigned this Feb 2, 2023
@rbtr rbtr added the dependencies Dependencies only. label Feb 2, 2023
@rbtr rbtr force-pushed the go1.20 branch 3 times, most recently from 33b59cc to 2ac71d5 Compare February 17, 2023 20:37
@rbtr rbtr force-pushed the go1.20 branch 2 times, most recently from 067b009 to 1f16e06 Compare March 1, 2023 17:53
@rbtr
update to go1.20
e1a4cf2 
Signed-off-by: Evan Baker <[email protected]>
@rbtr rbtr enabled auto-merge (squash) March 29, 2023 17:39
huntergregory
huntergregory reviewed Mar 29, 2023
View reviewed changes
Copy link
Contributor

@huntergregory huntergregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NPM changes lgtm. Let's see how pipelines fare

@rbtr
Copy link
Contributor Author

rbtr commented Mar 29, 2023 •
edited
Loading

@huntergregory everything is green except for Run Windows Cyclonus v2-windows which is broken/flake if I remember correctly?

@ramiro-gamarra
Copy link
Contributor

As of today, go 1.20.2 is the latest stable release, should we specify the minor version here?

@rbtr
Copy link
Contributor Author

rbtr commented Mar 29, 2023

As of today, go 1.20.2 is the latest stable release, should we specify the minor version here?

We will get the latest available patch versions automatically by only specifying the major.minor version

@rbtr rbtr merged commit 4dfd97c into Azure:master Mar 29, 2023
@rbtr rbtr deleted the go1.20 branch March 29, 2023 17:53
@huntergregory
Copy link
Contributor

@huntergregory everything is green except for Run Windows Cyclonus v2-windows which is broken/flake if I remember correctly?

Looks like a flake ya. Linux/Windows conformance are green so the NPM image works

rbtr added a commit that referenced this pull request Sep 8, 2023
@rbtr
update to go1.20 (#1781)
faf5f37 
Signed-off-by: Evan Baker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huntergregory huntergregory huntergregory left review comments

@ramiro-gamarra ramiro-gamarra ramiro-gamarra approved these changes

@matmerr matmerr Awaiting requested review from matmerr

@vakalapa vakalapa Awaiting requested review from vakalapa

@thatmattlong thatmattlong Awaiting requested review from thatmattlong thatmattlong is a code owner automatically assigned from Azure/acn-cns-reviewers

@timraymond timraymond Awaiting requested review from timraymond

Assignees

@rbtr rbtr

Labels
dependencies Dependencies only.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbtr @ramiro-gamarra @huntergregory