Update ClusterSubnetStates crd #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
previously approved these changes
Jan 25, 2023
rbtr
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update timestamp in ccs crd.
Reason for Change:
This is a CRD for AKS CNS scarcity feature. Scacity feature is a feature that allow DNC dynamically reserve IP. For example, the normal batch size is 16 and when CNS ask for more IPs, DNC always reserve 16 IPs or multiple 16 IPs. When we have scarcity feature, DNC is allowed to reserve even 1 IPs for CNS.
ccs timestamp is controlled by DNC so it belongs to status instead of spec. Then move it to status from spec. Spec is a desired target that controller send out. However, timestamp is a current status instead of the desired target. Status is the place to record the current status which is suitable for timestamp.