OSA - Remove FQDN parameters and update ensure_osa_aad flow #9083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
mboersma
approved these changes
Apr 12, 2019
Member
mboersma
left a comment
mboersma
left a comment
There was a problem hiding this comment.
lgtm, I just had a question about LongRunningOperation.
| resource_group_name=resource_group_name, resource_name=name, parameters=osamc) | ||
| result = sdk_no_wait(no_wait, client.create_or_update, | ||
| resource_group_name=resource_group_name, resource_name=name, parameters=osamc) | ||
| result = LongRunningOperation(cmd.cli_ctx)(result) |
Member
There was a problem hiding this comment.
We don't use result after this point in this method. Should it be returned? Why are we making a LongRunningOperation out of it if it isn't used?
tjprescott
suggested changes
Apr 16, 2019
| =============== | ||
| 2.3.22 | ||
| ++++++ | ||
| * Removing `--fqdn` flag on az openshift commands |
Member
There was a problem hiding this comment.
This is a breaking change and cannot be done with a simple patch version. This needs to call out the breaking change and be bumped to version 2.4.0
# Conflicts: # src/command_modules/azure-cli-acs/HISTORY.rst # src/command_modules/azure-cli-acs/azure/cli/command_modules/acs/_help.py # src/command_modules/azure-cli-acs/azure/cli/command_modules/acs/custom.py
Contributor
Author
|
@tjprescott can you give another look please ? Thanks |
tjprescott
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.