[functionapp] - fixes #8659 - app support for premium scale out #8947
Conversation
src/command_modules/azure-cli-appservice/azure/cli/command_modules/appservice/_help.py
Outdated
Show resolved
Hide resolved
src/command_modules/azure-cli-appservice/azure/cli/command_modules/appservice/_help.py
Outdated
Show resolved
Hide resolved
src/command_modules/azure-cli-appservice/azure/cli/command_modules/appservice/_help.py
Outdated
Show resolved
Hide resolved
src/command_modules/azure-cli-appservice/azure/cli/command_modules/appservice/_help.py
Outdated
Show resolved
Hide resolved
ankitkumarr
force-pushed
the
ankikuma-premium
branch
from
0b88e6c to
8fe2817
Compare
|
@yugangw-msft / @stevengum - looks like you made the last commit in My PR here needs |
|
@ankitkumarr should be okay to bump the dependency, thanks! |
ankitkumarr
force-pushed
the
ankikuma-premium
branch
from
8fe2817 to
d04d1c9
Compare
There was a problem hiding this comment.
Bumping this version to 0.41.0 will need the tests to be re-run & re-recorded if needed. Started a PR for this #8886 do you want to wait for this PR to be merged or do you want to run & record all the tests yourself as a part of this? Let me know. Thanks!
There was a problem hiding this comment.
Thanks for letting me know about that. I see that you have already rerecorded the tests in your PR. I can wait for your PR to be checked in (looks like it should be in a day or so?).
Please let me know once your PR is in, I can rebase and update mine.
ankitkumarr
force-pushed
the
ankikuma-premium
branch
5 times, most recently
from
7cb3364 to
79548d5
Compare
ankitkumarr
force-pushed
the
ankikuma-premium
branch
from
79548d5 to
b03e57c
Compare
|
@yugangw-msft, would you mind reviewing / merging this PR. It would be awesome if we can get this in as part of this release :) |
| short-summary: Get the App Service Plans for a resource group or a set of resource groups. | ||
| examples: | ||
| - name: Get the app service plans for a resource group or a set of resource groups. (autogenerated) | ||
| text: az functionapp plan show --name MyAppServicePlan --resource-group MyResourceGroup |
There was a problem hiding this comment.
Please take care of the extra white-spaces here in the next PR. I am merging it since we are running out of the time for the current release
6 participants
I have a local test foraz functionapp plan create --sku EP1settings, but I cannot commit them because these features are not exposed in all resource groups and can fail.Added the tests, with Elastic Premium being public now.
Soon,This can be updated when the underlying sdk is updated. Shouldn't affect things now.reservedInstanceCountproperty will be renamed, which may cause this command to not work. I will have to make another PR to update that.\cc @alexkarcher-msft @panchagnula @jeffhollan @ahmedelnably
Ahmed, let me know if you need me to make updates to help texts.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.