graph: support admin consent #8804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstr
suggested changes
Mar 18, 2019
src/command_modules/azure-cli-role/azure/cli/command_modules/role/custom.py
Outdated
Show resolved
Hide resolved
| def admin_consent(cmd, identifier): | ||
| import requests | ||
| from azure.cli.core.cloud import AZURE_PUBLIC_CLOUD | ||
| from azure.cli.core._profile import Profile |
Member
There was a problem hiding this comment.
Importing from private namespaces always raises my eyebrows. Is Profile something we should bring into the public interface?
Contributor
Author
There was a problem hiding this comment.
_profile is okay to use from core command modules which role, keyvault command modules have done that already, because we are always releasing them together.
src/command_modules/azure-cli-role/azure/cli/command_modules/role/_help.py
Show resolved
Hide resolved
marstr
approved these changes
Mar 19, 2019
This was referenced Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, CLI will do exactly like the "Grant Permission" button in portal and hence both "Application" and "Delegated" permissions can be handled.
This addresses the lingering ask in #7177 and #8310
//CC @paolosalvatori @jianghaolu
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.