BotService: 0.1.5 release #8384
Conversation
|
@tjprescott @williexu, any idea why the first lint check is failing on files not touched in this PR? I rebased to make sure my fork is up-to-date. |
...ommand_modules/azure-cli-botservice/azure/cli/command_modules/botservice/bot_publish_prep.py
Outdated
Show resolved
Hide resolved
.../azure-cli-botservice/azure/cli/command_modules/botservice/tests/latest/test_bot_commands.py
Outdated
Show resolved
Hide resolved
.../azure-cli-botservice/azure/cli/command_modules/botservice/tests/latest/test_bot_commands.py
Outdated
Show resolved
Hide resolved
src/command_modules/azure-cli-botservice/azure/cli/command_modules/botservice/kudu_client.py
Outdated
Show resolved
Hide resolved
Just looked into this, and it looks like it got addressed in 2c1c422. If you push another commit or rebase on the latest upstream/dev, this issue should be resolved. |
|
@tjprescott thanks for signing off! Can we get this merged in? @carlosscastro and I have a couple more changes that will go in on top of this PR 😄 |
|
Thanks for the contribution @stevengum! |
|
|
||
| @ResourceGroupPreparer(random_name_length=20) | ||
| def test_botservice_create_should_remove_invalid_char_from_name_when_webapp(self, resource_group): | ||
| bot_name = self.create_random_name(prefix='cli.', length=15) |
There was a problem hiding this comment.
I believe this breaks CLI's recording process because the new name with . removed doesn't match any entry in the create_random_name table.
Since I am bumping the subscription REST API version in #11886, I need to re-run all tests live but failed here. Did you record without . or manually edit the recording YAML: 03e5147#diff-4e739bb12b0f4e7932621ac65a0d6372R103
If so, we'd better change this test to unit test or live-only so that the test can follow the common process.
There was a problem hiding this comment.
As discussed with the author, the recording files were manually edited. This issue is addressed in #11935 by moving the tests into a LiveScenarioTest.
5 participants
Fixes: microsoft/botbuilder-tools#796
Fixes: microsoft/botbuilder-tools#858
Fixes: microsoft/botbuilder-tools#876
Fixes: microsoft/botbuilder-tools#887
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.