Skip to content

[Network] Fix DNS zone update --registration-vnets and --resolution-vnets #7993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjprescott merged 1 commit into from
Dec 6, 2018
Merged

[Network] Fix DNS zone update --registration-vnets and --resolution-vnets #7993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/command_modules/azure-cli-network/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Release History

2.2.10
++++++
* `dns zone update`: Finished issue where using "" to clear resolution and registration VNets didn't work.
* `application-gateway waf-config set`: Added `--exclusion` argument to support WAF exclusions.

2.2.9
Expand Down
4 changes: 2 additions & 2 deletions src/command_modules/azure-cli-network/azure/cli/command_modules/network/_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ def _validate_vnet_name_or_id(cmd, namespace):
names_or_ids = getattr(namespace, dest)
ids = []

if names_or_ids == [""] or not names_or_ids:
names_or_ids = []
if names_or_ids == [''] or not names_or_ids:
return

for val in names_or_ids:
if not is_valid_resource_id(val):
Expand Down
5 changes: 2 additions & 3 deletions src/command_modules/azure-cli-network/azure/cli/command_modules/network/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@

from collections import Counter, OrderedDict

from knack.log import get_logger

from msrestazure.azure_exceptions import CloudError
from msrestazure.tools import parse_resource_id, is_valid_resource_id, resource_id

from knack.log import get_logger

from azure.mgmt.trafficmanager.models import MonitorProtocol, ProfileStatus

# pylint: disable=no-self-use,no-member,too-many-lines,unused-argument
Expand Down Expand Up @@ -967,7 +967,6 @@ def update_dns_zone(instance, tags=None, zone_type=None, resolution_vnets=None,
instance.registration_virtual_networks = None
elif registration_vnets:
instance.registration_virtual_networks = registration_vnets

return instance


Expand Down