-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[Consumption]: Fixed transformer bugs for budget API to show notifications. #7971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 35 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
8089422
fix live tests for sas token urls to use datetime (#7866)
williexu 78cb801
Convert test back to scenario test. (#7862)
tjprescott 50fa3ef
Remove unused scripts. (#7860)
tjprescott bfe8048
fix get curren user id azure-graphrbac Breaking change fixes #7839 (#…
a-santamaria ec8454a
Use knack 0.5.1. (#7780)
tjprescott 2bdfdd4
test: make webjob tests record only as create command is unavailable …
yugangw-msft 1801ecc
Deprecate expand param. (#7868)
adewaleo 8cb5b57
Updated help.py - generate-sas example (#7873)
jochenvanwylick 0c3f3ea
Low priority vmss test and help update. (#7882)
adewaleo f899f2c
Added --force to az vm restart. Added simple test. (#7885)
adewaleo 584129a
Fix requests version > 2.20 (#7858)
tjprescott 5d6ead9
Bump CLI versions
yugangw-msft b70b6fb
[vm] Enable password and ssh key authentication during linux VM creat…
adewaleo 2c7c67c
Properly handle parsing of ids from -o tsv on windows. (#7898)
adewaleo 0d0c5c4
[Storage] bump mgmt sdk version to 3.1.0 and set new api-version to u…
williexu 82ce638
test: live test fixes in appservice, vm, resource (#7899)
yugangw-msft a262785
ci: fix build break (#7900)
yugangw-msft 0e77742
Updated adls version (#7859)
akharit 96837ab
core: support cross tenant resource provisioning for multi-tenant ser…
yugangw-msft cfef25b
core: fix the error on matching SP creds (#7923)
yugangw-msft 8c08da2
resource: fix live test failure of policyset (#7922)
yugangw-msft adcb813
[CI] reenable extension checking in CI (#7933)
williexu 0729c9f
BotService: Bugfixing, code refactoring, reorganization and UX revamp…
carlosscastro bb2981e
Close #7528. (#7920)
tjprescott d519d2d
Minor updates to core/generate_ssh_keys and batchai/_generate_ssh_key…
adewaleo 39d51fa
[image] create. Add --os-disk-caching parameter. (#7919)
adewaleo 30c09be
graph: support custom key identifier (#7913)
yugangw-msft e2d298a
BotService: fix tests, improve test robustness and update recordings …
carlosscastro b8fb3f3
webapp: Adding support for az webapp up (#7930)
panchagnula e72983f
core: fix a breaking in kv when run under service principal (#7946)
yugangw-msft a454bb4
Disable version check from CI. (#7958)
tjprescott 02b3f35
test: add test coverage for regression from auth (#7949)
yugangw-msft 047b79d
Fixed bugs for budget API to show notifications.
a3b87a5
Bump up version in setup
530b392
Merge branch 'dev' of https://github.com/Azure/azure-cli into dev
b8d145b
Revert the change from merging upstream
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,9 @@ | |
|
|
||
| Release History | ||
| =============== | ||
| 2.3.12 | ||
| ++++++ | ||
| * Minor fixes | ||
|
|
||
| 2.3.13 | ||
| ++++++ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
...cli/command_modules/consumption/tests/latest/recordings/test_consumption_budget_show.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| interactions: | ||
| - request: | ||
| body: null | ||
| headers: | ||
| Accept: [application/json] | ||
| Accept-Encoding: ['gzip, deflate'] | ||
| CommandName: [consumption budget show] | ||
| Connection: [keep-alive] | ||
| Content-Type: [application/json; charset=utf-8] | ||
| ParameterSetName: [--budget-name] | ||
| User-Agent: [python/3.6.5 (Windows-10-10.0.17763-SP0) msrest/0.6.2 msrest_azure/0.4.34 | ||
| azure-mgmt-consumption/2.0.0 Azure-SDK-For-Python AZURECLI/2.0.52] | ||
| accept-language: [en-US] | ||
| method: GET | ||
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Consumption/budgets/havTest01?api-version=2018-01-31 | ||
| response: | ||
| body: {string: '{"id":"subscriptions/f2ddfccd-77af-44b8-b0cd-38500f84b95e/providers/Microsoft.Consumption/budgets/havTest01","name":"havTest01","type":"Microsoft.Consumption/budgets","eTag":"\"1d4877ebd701de2\"","properties":{"timePeriod":{"startDate":"2018-11-01T00:00:00Z","endDate":"2018-12-31T00:00:00Z"},"timeGrain":"Monthly","amount":800.0,"currentSpend":{"amount":41.712656643888759,"unit":"USD"},"category":"Cost","notifications":{"actual_GreaterThan_25_Percent":{"enabled":true,"operator":"GreaterThan","threshold":25.00,"contactEmails":["mar@microsoft.com"],"contactRoles":[],"contactGroups":[]},"actual_GreaterThan_75_Percent":{"enabled":true,"operator":"GreaterThan","threshold":75.00,"contactEmails":["mar@microsoft.com"],"contactRoles":[],"contactGroups":[]},"actual_GreaterThan_100_Percent":{"enabled":true,"operator":"GreaterThan","threshold":100.0,"contactEmails":["mar@microsoft.com"],"contactRoles":[],"contactGroups":[]}},"filters":{"resourceGroups":[],"resources":[],"meters":[],"tags":{}}}}'} | ||
| headers: | ||
| access-control-allow-origin: ['*'] | ||
| cache-control: [no-cache] | ||
| content-length: ['996'] | ||
| content-type: [application/json; charset=utf-8] | ||
| date: ['Mon, 03 Dec 2018 23:33:26 GMT'] | ||
| expires: ['-1'] | ||
| pragma: [no-cache] | ||
| session-id: [8e7644fe-1025-466c-a0c6-17adf1ee8b2e] | ||
| strict-transport-security: [max-age=31536000; includeSubDomains] | ||
| transfer-encoding: [chunked] | ||
| vary: [Accept-Encoding] | ||
| x-content-type-options: [nosniff] | ||
| status: {code: 200, message: OK} | ||
| version: 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.