Skip to content

Move extension logic into core #7653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
williexu merged 6 commits into from
Oct 24, 2018
Merged

Move extension logic into core #7653

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3623356
moved previous 'extensions' event handling logic
williexu Oct 23, 2018
09c15e9
moved all extension management utility to core
williexu Oct 24, 2018
34b4c6c
fix ref
williexu Oct 24, 2018
03367e2
core package
williexu Oct 24, 2018
407d012
fix reference
williexu Oct 24, 2018
a32eb67
renamed to register_global_transforms
williexu Oct 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/azure-cli-core/azure/cli/core/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def __init__(self, **kwargs):
from azure.cli.core.commands.arm import (
register_ids_argument, register_global_subscription_argument)
from azure.cli.core.cloud import get_active_cloud
from azure.cli.core.extensions import register_extensions
from azure.cli.core.commands.transform import register as register_transform
Comment thread
williexu marked this conversation as resolved.
Outdated
from azure.cli.core._session import ACCOUNT, CONFIG, SESSION

from knack.util import ensure_dir
Expand All @@ -55,7 +55,7 @@ def __init__(self, **kwargs):
self.cloud = get_active_cloud(self)
logger.debug('Current cloud config:\n%s', str(self.cloud.name))

register_extensions(self)
register_transform(self)
register_global_subscription_argument(self)
register_ids_argument(self) # global subscription must be registered first!

Expand Down Expand Up @@ -110,7 +110,7 @@ def load_command_table(self, args):
import traceback
from azure.cli.core.commands import (
_load_module_command_loader, _load_extension_command_loader, BLACKLISTED_MODS, ExtensionCommandSource)
from azure.cli.core.extension import (
from azure.cli.core.extensions import (
get_extensions, get_extension_path, get_extension_modname)

def _update_command_table_from_modules(args):
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli-core/azure/cli/core/commands/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
CLI_POSITIONAL_PARAM_KWARGS, CONFIRM_PARAM_NAME)
from azure.cli.core.commands.parameters import (
AzArgumentContext, patch_arg_make_required, patch_arg_make_optional)
from azure.cli.core.extension import get_extension
from azure.cli.core.extensions import get_extension
from azure.cli.core.util import get_command_type_kwarg, read_file_content, get_arg_list, poller_classes
import azure.cli.core.telemetry as telemetry

Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli-core/azure/cli/core/commands/client_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

from azure.cli.core import __version__ as core_version
import azure.cli.core._debug as _debug
from azure.cli.core.extension import EXTENSIONS_MOD_PREFIX
from azure.cli.core.extensions import EXTENSIONS_MOD_PREFIX
from azure.cli.core.profiles._shared import get_client_class, SDKProfile
from azure.cli.core.profiles import ResourceType, CustomResourceType, get_api_version, get_sdk

Expand Down
0 ...re/azure/cli/core/extensions/transform.py → ...core/azure/cli/core/commands/transform.py
View file
Open in desktop
File renamed without changes.
205 changes: 0 additions & 205 deletions src/azure-cli-core/azure/cli/core/extension.py
View file
Open in desktop

This file was deleted.

Loading