Skip to content

Added interactive events to core #7632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
williexu merged 1 commit into from
Oct 23, 2018
Merged

Added interactive events to core #7632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/azure-cli-core/azure/cli/core/commands/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@

EVENT_INVOKER_PRE_CMD_TBL_TRUNCATE = 'CommandInvoker.OnPreCommandTableTruncate'
EVENT_INVOKER_ON_TAB_COMPLETION = 'CommandInvoker.OnTabCompletion'

# special events used for Interactive and Alias extension communication
EVENT_INTERACTIVE_PRE_COMPLETER_TEXT_PARSING = 'Interactive.PreCompleterTextParsing'
EVENT_INTERACTIVE_POST_SUB_TREE_CREATE = 'Interactive.PostSubTreeCreate'
Copy link
Member

@tjprescott tjprescott Oct 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where would these be called in the core, and why are they needed?

Copy link
Contributor Author

@williexu williexu Oct 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They will be called from the interactive/alias extensions. The scenario is extensions needing to communicate with one another through the CLI core.
This should only be reserved for extensions that are tightly integrated into the CLI.