Skip to content

Removing Warnings for Cloudshell Proxy #7605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Travis Prescott (tjprescott) merged 5 commits into from
Oct 18, 2018
Merged

Removing Warnings for Cloudshell Proxy #7605

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0566acd
removing warnings for cloudshell proxy
Oct 18, 2018
fff274a
updating code owners for the container modules
Oct 18, 2018
2948e92
Updating how env var is accessed
Oct 18, 2018
67c2c95
fixing formatting error in string message
Oct 18, 2018
a42c576
removing unused import
Oct 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
/src/command_modules/azure-cli-cdn/ @tjprescott
/src/command_modules/azure-cli-cosmosdb/ @dmakwana
/src/command_modules/azure-cli-cloud/ @yugangw-msft
/src/command_modules/azure-cli-container/ @yolo3301
/src/command_modules/azure-cli-container/ @samkreter
/src/command_modules/azure-cli-consumption/ @sandeepnl
/src/command_modules/azure-cli-dls/ @lewu-msft
/src/command_modules/azure-cli-eventgrid/ @kalyanaj
Expand Down
5 changes: 5 additions & 0 deletions src/command_modules/azure-cli-acs/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

Release History
===============

2.3.9
+++++
* Minor fixes

2.3.8
+++++
* Minor fixes.
Expand Down
12 changes: 5 additions & 7 deletions src/command_modules/azure-cli-acs/azure/cli/command_modules/acs/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1357,16 +1357,14 @@ def aks_browse(cmd, client, resource_group_name, name, disable_browser=False, li
raise CLIError("Couldn't find the Kubernetes dashboard pod.")
# launch kubectl port-forward locally to access the remote dashboard
if in_cloud_console() and enable_cloud_console_aks_browse:
logger.warning('***WARNING***')
logger.warning('Browsing the kubernetes dashboard in Cloud Shell is an alpha feature.')
logger.warning('The browse URL is currently obfuscated but not authenticated.')
logger.warning('Do not share this URL.')
if not prompt_y_n('Proceed?'):
raise CLIError("Browse aborted.")
# TODO: better error handling here.
response = requests.post('http://localhost:8888/openport/8001')
result = json.loads(response.text)
logger.warning('To view the console, please open % in a new tab', result['url'])
term_id = os.environ.get('ACC_TERM_ID')
if term_id:
response = requests.post('http://localhost:8888/openLink/{}'.format(term_id),
Comment thread
samkreter marked this conversation as resolved.
json={"url": result['url']})
logger.warning('To view the console, please open %s in a new tab', result['url'])
else:
logger.warning('Proxy running on %s', proxy_url)

Expand Down
2 changes: 1 addition & 1 deletion src/command_modules/azure-cli-acs/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
logger.warn("Wheel is not available, disabling bdist_wheel hook")
cmdclass = {}

VERSION = "2.3.8"
VERSION = "2.3.9"
CLASSIFIERS = [
'Development Status :: 5 - Production/Stable',
'Intended Audience :: Developers',
Expand Down