Skip to content

Fixed non-working example for mysql db create #7557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Travis Prescott (tjprescott) merged 5 commits into from
Oct 25, 2018
Merged

Fixed non-working example for mysql db create #7557

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
37e743b
Update _help.py
JasonRShaver Oct 12, 2018
3a61e9c
Update HISTORY.rst
JasonRShaver Oct 12, 2018
4d33225
Update setup.py
JasonRShaver Oct 12, 2018
a80b379
Merge branch 'dev' into JasonRShaver-patch-1
tjprescott Oct 25, 2018
5c36526
Fix placeholder
tjprescott Oct 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/command_modules/azure-cli-rdbms/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
Release History
===============

0.3.3
+++++
* Fixed broken mysql db create example

0.3.2
+++++
* Add support for MariaDB service
Expand Down
4 changes: 2 additions & 2 deletions src/command_modules/azure-cli-rdbms/azure/cli/command_modules/rdbms/_help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,9 @@ def add_helps(command_group, server_type):
short-summary: Create a {0} database.
examples:
- name: Create database 'testdb' in the server 'testsvr' with the default parameters.
text: az {1} db create -g testgroup -s testsvr -n testdb
text: az {1} db create -g testgroup -s testsvr -n testdb --admin-user myadmin --admin-password <server_admin_password> --sku-name GP_Gen4_2 --version 5.7
- name: Create database 'testdb' in server 'testsvr' with a given character set and collation rules.
text: az {1} db create -g testgroup -s testsvr -n testdb --charset {{valid_charset}} --collation {{valid_collation}}
text: az {1} db create -g testgroup -s testsvr -n testdb --charset {{valid_charset}} --collation {{valid_collation}} --admin-user myadmin --admin-password <server_admin_password> --sku-name GP_Gen4_2 --version 5.7

@tjprescott Travis Prescott (tjprescott) Oct 15, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "placeholder" syntax should be the same. Here you have {this} mixed with <this>. Use the double curly braces.

""".format(server_type, command_group)
helps['{} db delete'.format(command_group)] = """
type: command
Expand Down
2 changes: 1 addition & 1 deletion src/command_modules/azure-cli-rdbms/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
logger.warn("Wheel is not available, disabling bdist_wheel hook")
cmdclass = {}

VERSION = "0.3.2"
VERSION = "0.3.3"
CLASSIFIERS = [
'Development Status :: 4 - Beta',
'Intended Audience :: Developers',
Expand Down