Skip to content

Conversation

@mboersma
Copy link
Member

az aks get-credentials would create the ~/.kube/config file with permission for others to read and write it. This instead creates the file with 0600 permissions on non-Windows platforms, and warns the user if an existing config file doesn't have those permissions.


This checklist is used to make sure that common guidelines for a pull request are followed.

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • I adhere to the Command Guidelines.

@promptws
Copy link

View a preview at https://prompt.ws/r/Azure/azure-cli/6399
This is an experimental preview for @microsoft users.

@codecov-io
Copy link

codecov-io commented May 22, 2018

Codecov Report

Merging #6399 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##           dev   #6399   +/-   ##
===================================
  Coverage    0%      0%           
===================================
  Files       11      11           
  Lines      133     133           
  Branches     9       9           
===================================
  Misses     133     133

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee4bb56...8f8dd0a. Read the comment docs.

@mboersma mboersma force-pushed the secure-kube-config-perms branch from d0aadcb to d484dba Compare May 22, 2018 17:40
@mboersma
Copy link
Member Author

mboersma commented May 22, 2018

I rebased against master but I'm still seeing a failure in Travis CI. Any ideas?

The following modules have invalid versions:
azure-cli-core
azure-cli

Update: never mind, I see #6407.

@williexu
Copy link
Contributor

@mboersma I see you saw #6407
Just rebase again and you should get the update :)

@mboersma mboersma force-pushed the secure-kube-config-perms branch from d484dba to 8f8dd0a Compare May 22, 2018 20:47
@mboersma
Copy link
Member Author

@williexu could this get reviewed soon? I'd like to get this bug fix in the next az release.

@williexu williexu merged commit 74a6f9b into Azure:dev May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants