Skip to content

Conversation

@yugangw-msft
Copy link
Contributor

@yugangw-msft yugangw-msft commented Aug 4, 2016

@ahmetalpbalkan , i do it on newly created file, just in case people might have tweaked to other permissions they prefer.

@ahmetb
Copy link
Contributor

ahmetb commented Aug 4, 2016

@yugangw-msft doesn't python have an open(2) equivalent call where you w+ and get to specify chmod mode?

@ahmetb
Copy link
Contributor

ahmetb commented Aug 4, 2016

I see os.open will do the job for you

print os.open.__doc__
open(filename, flag [, mode=0777]) -> fd

Open a file (for low level IO).

I don't find the current patch with new_file clean.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this always remove the contents you just wrote one line above? if you need file to be truncated when you open it, you can use os.O_TRUNC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this is working code. and a little surprising to me. Checkout this SO thread

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the flag appears do the same, but more consistent, so i take your suggestion.
Note, barring the effect of umask, the whole change will always update the file mode, even a file which a user has specifically tweaked the permission. i thought it would be an issue, but i don't have strong opinions

@yugangw-msft yugangw-msft force-pushed the filemode branch 2 times, most recently from c06439e to b2c5c44 Compare August 5, 2016 03:37
@ahmetb
Copy link
Contributor

ahmetb commented Aug 5, 2016

even a file which a user has specifically tweaked the permission.

I think this is going to be fine. on the flip side, if users make an error and make their files too open, you'll be fixing it for them.

for instance, programs like /usr/bin/ssh don't work with private key files if they are readable by other users as well.

@yugangw-msft yugangw-msft merged commit 7325e08 into Azure:master Aug 5, 2016
formulahendry pushed a commit to formulahendry/azure-cli that referenced this pull request Aug 11, 2016
* fix Azure#571: accessTokens.json is 0644

* for review feedback
@yugangw-msft yugangw-msft deleted the filemode branch September 18, 2016 21:25
00Kai0 pushed a commit to 00Kai0/azure-cli that referenced this pull request Apr 7, 2021
00Kai0 pushed a commit to 00Kai0/azure-cli that referenced this pull request Apr 7, 2021
* [image-copy] update to version 0.2.0

* [image-copy] update index for version 0.2.0

* switch to 2019-04-01 api version and enable windows agent pool (Azure#612)

* fixing az support for agent pools and mc

* vendor in 2019-04-01 SDK

* enableing windows profile

* merge the latest official SDK

* add secure prompt for windows admin password

* fixing warnings

* Policies should be global, remove location parameter and default it (Azure#620)

* bug fixes: missing service principal and network profile parameter validation (Azure#626)

* Pin max CLI version. (Azure#630)

* Update front door index to 0.1.5 (Azure#632)

* Fixes Azure#629. (Azure#631)

* Update index.json. (Azure#640)

* Add new version of aks-preview in index.json (Azure#634)

* Azure Event Grid 0.4.1 (Azure#633)

* Azure Event Grid 0.4.1

* fix white space

* fix style issues

* style fixes

* style comment spaces fixes

* more style fixes

* mossing hesder

* Address CR comment

* move json generated SDK files to vendored_sdks folder and update related imports

* revert index changes until we publish final extension

* Address CR comments by removing unnecessary parameters

* Fix style

* update index.json file

* fix index.json after running azdev extension update-index

* fix index.json after running azdev extension update-index

* add missing __init__.py

* fix init files

* fix new line in init files

* update location of vendored_sdks and update index.json

* fix help errors and update index.json file accordingly

* [aks-preview]: fix python3-only super() syntax (Azure#641)

* [storage-preview] release azcopy 10.0.9 (Azure#639)

* [storage-preview] release azcopy 10.0.9

* Fix indent

* [storage-preview] pulish 0.2.4 (Azure#642)

* App Insights control plane (Azure#600)

* Remove 'preview' from Dev Spaces (Azure#638)

* Update PULL_REQUEST_TEMPLATE.md (Azure#645)

Refer to azdev.

* setting default vm size for windows (Azure#637)

* SQL: make "up" command work end to end (Azure#644)

* Update requirements.txt

Bump for Jinja security vulnerability

* Update to RP standard release 3.5 (Azure#29) (Azure#627)

* NFSAAS-2102 update to R3.5 (Azure#29)

* Nfsaas 2102 update to r3 5 (Azure#30)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* Nfsaas 2102 update to r3 5 (Azure#31)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* Nfsaas 2102 update to r3 5 (Azure#32)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* Nfsaas 2102 update to r3 5 (Azure#33)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* Nfsaas 2102 update to r3 5 (Azure#34)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* Nfsaas 2102 update to r3 5 (Azure#35)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* Nfsaas 2102 update to r3 5 (Azure#36)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* Nfsaas 2102 update to r3 5 (Azure#37)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* Nfsaas 2102 update to r3 5 (Azure#38)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* Nfsaas 2102 update to r3 5 (Azure#39)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* Nfsaas 2102 update to r3 5 (Azure#40)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* Merge azure master back to fork. (Azure#41)

* Add new version of aks-preview in index.json (Azure#634)

* Azure Event Grid 0.4.1 (Azure#633)

* Azure Event Grid 0.4.1

* fix white space

* fix style issues

* style fixes

* style comment spaces fixes

* more style fixes

* mossing hesder

* Address CR comment

* move json generated SDK files to vendored_sdks folder and update related imports

* revert index changes until we publish final extension

* Address CR comments by removing unnecessary parameters

* Fix style

* update index.json file

* fix index.json after running azdev extension update-index

* fix index.json after running azdev extension update-index

* add missing __init__.py

* fix init files

* fix new line in init files

* update location of vendored_sdks and update index.json

* fix help errors and update index.json file accordingly

* [aks-preview]: fix python3-only super() syntax (Azure#641)

* [storage-preview] release azcopy 10.0.9 (Azure#639)

* [storage-preview] release azcopy 10.0.9

* Fix indent

* [storage-preview] pulish 0.2.4 (Azure#642)

* App Insights control plane (Azure#600)

* Remove 'preview' from Dev Spaces (Azure#638)

* Update PULL_REQUEST_TEMPLATE.md (Azure#645)

Refer to azdev.

* setting default vm size for windows (Azure#637)

* SQL: make "up" command work end to end (Azure#644)

* Update requirements.txt

Bump for Jinja security vulnerability

* Update readme to reflect the latest SQL DB status

* SQL up: update a typo

* Update index.json for backwards compatability for Dev Spaces (Azure#648)

* update index.json for backwards compatability

* fix maxCliVersion for dev-spaces-preview

* revert dev-spaces minCliCoreVersion

* update metadata for dev-spaces and dev-spaces-preview

* update metadata for dev-spaces and dev-spaces-preview

* sync workspaces

* 0.5.0 release for Azure DevOps (Azure#653)

* [AKS]customizing node resource group (Azure#636)

* customizing node resource group

* make 2.0 and 3.0 python work

* add index

* Onboard Azure Machine Learning Service CLI (Azure#655)

* [storage-preview] pulish 0.2.5 (Azure#657)

* [AKS] Add Azure policy addon (Azure#651)

* Add the Azure Policy Addon Support

* Add azure-policy addon

* Allow azure-policy addon in create

* Update the index

* Add the missing parameter description

* 0.6.0 release for Azure DevOps (Azure#660)

* Upgrade AppConfig extension version from 0.4.0 to 0.5.0 (Azure#661)

* Upgrade AppConfig extension verstion from 0.4.0 to 0.5.0

* format downloadUrl

* update wheel version to 0.30.0

* Update service principal secret for windows nodes (Azure#662)

* Release storage-preview 0.2.5 (Azure#663)

* Remove extra + (Azure#664)

* 0.7.0 release for Azure DevOps (Azure#666)

* 0.7.0 release for Azure DevOps

* update sha

* fix

* remove botservice from index.json (Azure#667)

* [image-copy] fix temp_rg default valuet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants